Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alphabetizes the modules in src/Modules.js #441

Merged
merged 2 commits into from
Nov 11, 2018

Conversation

kevinzluo
Copy link

@kevinzluo kevinzluo commented Oct 24, 2018

Fixes #375

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@kevinzluo
Copy link
Author

Hello. It appears another user completed this task as well. Was my GCI task duplicated?

@adisapphire
Copy link
Member

Great Work!
Thanks for the PR.

@tech4GT
Copy link
Member

tech4GT commented Oct 25, 2018

@Mridul97 Please have a look at this, I am seeing multiple pull requests for the same issue, like #444
Any idea why this is happening?

@kevinzluo
Copy link
Author

I believe it is because the task was listed multiple times on the GCI Task List. I saw another instance of it yesterday.

@tech4GT
Copy link
Member

tech4GT commented Oct 25, 2018

Oh, we need to fix this!! @Souravirus @SidharthBansal I need your help here!

@Souravirus
Copy link
Member

Yeah I can see two instances of it https://codein.withgoogle.com/dashboard/tasks/5257097257156608/ and https://codein.withgoogle.com/dashboard/tasks/6549673218146304/ . @tech4GT I don't have rights to delete a task. @SidharthBansal or @jywarren can surely help with this.

@jywarren
Copy link
Member

jywarren commented Oct 25, 2018 via email

@tech4GT
Copy link
Member

tech4GT commented Oct 26, 2018

Yeah, we can do it this one time I guess, I'll take a look at the dashboard to make sure that there are no duplicate tasks though.

@ghost ghost assigned jywarren Nov 11, 2018
@ghost ghost added the in-progress label Nov 11, 2018
@jywarren jywarren merged commit 1311119 into publiclab:main Nov 11, 2018
@welcome
Copy link

welcome bot commented Nov 11, 2018

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://sequencer.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@ghost ghost removed the in-progress label Nov 11, 2018
@jywarren
Copy link
Member

OK, merged this one and I left a notice on another saying we'll give credit but are closing... thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants