-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alphabetizes the modules in src/Modules.js #441
Conversation
Hello. It appears another user completed this task as well. Was my GCI task duplicated? |
Great Work! |
I believe it is because the task was listed multiple times on the GCI Task List. I saw another instance of it yesterday. |
Oh, we need to fix this!! @Souravirus @SidharthBansal I need your help here! |
Yeah I can see two instances of it https://codein.withgoogle.com/dashboard/tasks/5257097257156608/ and https://codein.withgoogle.com/dashboard/tasks/6549673218146304/ . @tech4GT I don't have rights to delete a task. @SidharthBansal or @jywarren can surely help with this. |
Can we give credit to all correct solutions and only merge one? If so, can
you indicate which should get approved? (Or just approve them?) If people
did the work right, we can give credit and just watch out for this in the
future!
Thanks all!
…On Thu, Oct 25, 2018, 4:29 PM Sourav Sahoo ***@***.*** wrote:
Yeah I can see two instances of it
https://codein.withgoogle.com/dashboard/tasks/5257097257156608/ and
https://codein.withgoogle.com/dashboard/tasks/6549673218146304/ . @tech4GT
<https://github.com/tech4GT> I don't have rights to delete a task.
@SidharthBansal <https://github.com/SidharthBansal> or @jywarren
<https://github.com/jywarren> can surely help with this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#441 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ3kRSOugPNyCs3nVnYqm6Pn9Hsk5ks5uoh74gaJpZM4X4WDk>
.
|
Yeah, we can do it this one time I guess, I'll take a look at the dashboard to make sure that there are no duplicate tasks though. |
Congrats on merging your first pull request! 🙌🎉⚡️ |
OK, merged this one and I left a notice on another saying we'll give credit but are closing... thanks! |
Fixes #375
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!