Add resize module

[JKusio]

Added resize module.
If you set resize value equal to 100%, the image will get twice as big, and when you set -100%, the image will be two times smaller.

It is my first module, so if something is wrong, tell me, and I'll fix it 😄

[JKusio]

#435

Can you review it @publiclab/reviewers? 😃

[tech4GT]

This looks quite good to me, a couple of things though

• Can you please add a screenshot of your work, it would make the review process easier 😄
• I see you have modified the test file, please explain that?

[tech4GT]

Thanks for your pull request! 😊

[JKusio]

It's hard to review it based on screenshots because it's hard to see a difference. But I'll add them when I get home.
I've changed the test file because I did some previous pull request with blend module, and now I've checked that there was an unused variable, and the test was pasted twice.

[JKusio]

In browser:
When resize is set to 100%
https://prnt.sc/lc0sg8

When resize is set to -25%
https://prnt.sc/lc0st9

Original image
https://prnt.sc/lc0syl

+25% resize
https://prnt.sc/lc0t34

-25% resize
https://prnt.sc/lc0t6x

[tech4GT]

Good work here!! 🎉

[jywarren]

This does look great! I wanted to ask, what if each percentage is taken as a proportion of the original size, where 125% means 25% bigger, and 75% means 25% smaller? In that model, a negative value would be meaningless. What do you think?

[jywarren]

Also, as a follow-up issue, we might add a resize by pixel height and width, which we can make compatible with the percentage based interface. But we can open an issue later!

This is really cool! Thanks for your hard work here!!!

[JKusio]

Ok, I've changed the resize calculation, and now it's taken as proportion.

However, I've got a questions that would help me understand this code fully, because I've copied some parts from other modules.

What this code does?
progressObj.stop(true); progressObj.overrideFlag = true;

[jywarren]

This manages the progress bar UI -- it may be documented in the readmes, but we may need to hear from @tech4GT once he is no longer as busy with school!

…

On Tue, Oct 30, 2018 at 4:15 PM KusioDev ***@***.***> wrote: Ok, I've changed the resize calculation, and now it's taken as proportion. However, I've got a questions that would help me understand this code fully, because I've copied some parts from other modules. What this code does? progressObj.stop(true); progressObj.overrideFlag = true; — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#451 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ7matMuZajEPuGSJ0TJM9oM7zfCjks5uqLMkgaJpZM4X-Ef2> .

[jywarren]

Is this otherwise ready? Thank you!!!

[JKusio]

I think it is 😄

[jywarren]

🙌🏽⚡⚡🚀