Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contrast module #463

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Conversation

Mridul97
Copy link

Fixes #157

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@Mridul97
Copy link
Author

Mridul97 commented Nov 11, 2018

Added Contrast Module! The module will accept values between -100 and 100!
Some screenshots of the output:

Original Picture:
ss_23

Contrast : 30
ss_24

Contrast : 70
ss_25

@Mridul97 Mridul97 mentioned this pull request Nov 11, 2018
@jywarren
Copy link
Member

This is looking great, but I think it may need to be rebased since some time has passed. But very grateful for this new module!!!

@Mridul97
Copy link
Author

I have rebased it. Please have a look! 😃

@jywarren
Copy link
Member

Hmm, do you know why the tests are failing? If it seems unrelated to your work you could close and reopen to rerun the tests...

Thanks @Mridul97 !!

@Mridul97 Mridul97 closed this Nov 13, 2018
@Mridul97 Mridul97 reopened this Nov 13, 2018
@Mridul97
Copy link
Author

In the job log, It is showing: Error: Cannot find module './modules/Contrast' from '/home/travis/build/publiclab/image-sequencer/src'. Trying to figure out why this is happening.

@Mridul97
Copy link
Author

Its solved. Please have a look! 😃

@jywarren
Copy link
Member

Perfect, great work!!!

@jywarren jywarren merged commit 4bdc5b6 into publiclab:main Nov 13, 2018
@jywarren
Copy link
Member

Wow, this project is really moving fast! So many new modules... 👍

You've really been doing good work :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants