GCI task pull request

[harshkhandeparkar]

Fixes #345

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[welcome]

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

[tsparksh]

Thank you 😃 ! Please add link to issue like this

Simply remove square brackets

Fixes #[345]

[tsparksh]

Maybe it would be better to transfer the styles from js in a .css file or <style> tag?
And also can you send a GIF or screenshot of your work, please?

[jywarren]

I love this gif!!!!!! Thanks keep up the great work :-)))

…

On Thu, Nov 15, 2018, 10:00 AM Sparks ***@***.*** wrote: Also maybe it would be better to remove the styles in a .css file or <style> tag? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#474 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJzsx_CbT1t_FLTwzcu_sQVB8NgM0ks5uvYFigaJpZM4YeTds> .

[harshkhandeparkar]

Thanks for the tips. I am new so I was not familiar with the styling. Also I accepted the GCI task but got no response.

[harshkhandeparkar]

I might have beautified the file by mistake. Is that a problem?

[tsparksh]

I might have beautified the file by mistake. Is that a problem?

I guess no.

Thanks for the tips. I am new so I was not familiar with the styling. Also I accepted the GCI task but got no response.

Please make changes #474 (comment) and attach a gif so that the mentors can see the result of your work.

[harshkhandeparkar]

Maybe it would be better to transfer the styles from js in a .css file or <style> tag?
And also can you send a GIF or screenshot of your work, please?

Added the styling to demo.css file. GIF has also been provided.

[tsparksh]

Looks good to me. Thank you!

[aashna27]

@harshkhandeparkar you have done great work. Thanks a lot.Good work with the spaces 😉 just a few more areas to remove them because i beieve the spaces weren't there before.

[aashna27]

[aashna27]

@harshkhandeparkar awesome!! 👍

Some work is needed

[aashna27]

@harshkhandeparkar I am sorry the new commit again has some spacing issues.

[jywarren]

This looks great thank you!!!!! Great teamwork, too, folks!

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://sequencer.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!