Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align add-step button with select-module input #501

Merged
merged 1 commit into from
Nov 30, 2018
Merged

align add-step button with select-module input #501

merged 1 commit into from
Nov 30, 2018

Conversation

bhavayAnand9
Copy link
Member

@bhavayAnand9 bhavayAnand9 commented Nov 27, 2018 •
edited
Loading

Fixes
Align Add Step button with More module... select input.

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@Rishabh570
Copy link

Hi @bhavayAnand9, can you share a screenshot your changes?
Thanks!

@bhavayAnand9
Copy link
Member Author

screen shot 2018-11-30 at 13 44 24

@Rishabh570
Copy link

Oh cool! This looks great!! BTW which issues this resolves?

@bhavayAnand9
Copy link
Member Author

I was a simple fix so I didn't create an issue for it. I hope it's ok

@jywarren
Copy link
Member

Nice, thanks a lot!!!

@jywarren jywarren merged commit f152a78 into publiclab:main Nov 30, 2018
@Rishabh570
Copy link

Ah, great work anyways 🎉

@bhavayAnand9 bhavayAnand9 deleted the mybranch branch November 30, 2018 18:09
@Rishabh570 Rishabh570 mentioned this pull request Dec 1, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhavayAnand9 @Rishabh570 @jywarren