Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slider now goes all the way to right & left #510

Merged
merged 1 commit into from
Nov 30, 2018
Merged

slider now goes all the way to right & left #510

merged 1 commit into from
Nov 30, 2018

Conversation

bhavayAnand9
Copy link
Member

Fixes #507

here's a simple fix for slider not going all the way to right & left. It was due to form-control class in the bootstrap library which add padding of 12px to right & left.
This PR is adding a form-control class which overrides the padding settings of the bootstrap library.

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@jywarren jywarren merged commit 2161d58 into publiclab:main Nov 30, 2018
@jywarren
Copy link
Member

Great work!

@bhavayAnand9 bhavayAnand9 deleted the edits branch November 30, 2018 23:46
@kevinzluo
Copy link

kevinzluo commented Dec 4, 2018

Hi. I actually found out that form-control is a bootstrap class that also controls the formatting of input fields. So by redefining the form-control class, we are actually disrupting the formatting of other input types.

For example, the field in the contrast module is now too close to the edges:
image

Compared to before:
image

My suggestion is that instead of doing .form-control: {...} in the css, we should use .form-control[type="range"] {...}. which gives the desired.
image

I feel like this would make a good FTO issue. What would you advise, @jywarren ?

@bhavayAnand9
Copy link
Member Author

Thanks, @kevinzluo for pointing that out. I didn't notice that it was also affecting other inputs too. I'll create an issue for it and maybe some maintainer will assign an FTO label to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brightness slider is not going all the way
3 participants