Add grid of thumbnails #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2018
|
This is super! Great work both of you!!! |
|
@jywarren I've claimed this task on GCI. There's only 4 hours left on it so it might expire soon! Thanks! |
|
I just approved your task, awesome!😄 |
|
Wow I really appreciate the speedy response from you guys! <3 public lab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #247 (comment)
A continuation of #535, this PR includes all its features while improving on the UI of the solution. Here's a screenshot:
Images are zoomed in for better viewing, and scaled to fit a square div without affecting aspect ratio. Icons are overlaid above as well.
@okonek is welcome to apply these changes to his PR as I don't have push access to his branch.