TakePhoto functionality added #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aashna27 This looks great!! I'll try this out in my browser and then we can merge!! Great work! 😄 |
|
oh cool, is it possible to see a screenshot of this or even a gif? Very
cool, thanks Aashna!
…On Mon, Dec 17, 2018 at 4:46 PM aashna27 ***@***.***> wrote:
@aashna27 <https://github.com/aashna27> requested your review on: #549
<#549> TakePhoto
functionality added.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#549 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ5wBIr_gf01NtbiyhN-zrCcOggmxks5u6BB_gaJpZM4ZXKjp>
.
|
|
@jywarren i have attached a gif in the pull request. |
tech4GT
approved these changes
Dec 19, 2018
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>
ghost
assigned
|
I think we are ready to merge here! 🎉 |
|
This is really cool by the way!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494
Thanks!