Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Gif Generation #561

Merged
merged 3 commits into from
Dec 28, 2018
Merged

Fixed Gif Generation #561

merged 3 commits into from
Dec 28, 2018

Conversation

harshkhandeparkar
Copy link
Member

@harshkhandeparkar harshkhandeparkar commented Dec 27, 2018 •
edited
Loading

Fixes #557

GIF generation no longer adds the preview thumbnails.

gif-fixed-sequencer

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

tech4GT and others added 3 commits December 27, 2018 19:00
@tech4GT
update dist
8e8281a 
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>

dist update

Revert "dist update"

This reverts commit 9ee2a98.
Merge remote-tracking branch 'upstream/main' into main
4774f8f
Fix Gif
936da99
@harshkhandeparkar
Copy link
Member Author

@tech4GT please review this.

tech4GT
tech4GT approved these changes Dec 28, 2018
View reviewed changes
Copy link
Member

@tech4GT tech4GT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done Harsh!! 🎉

@tech4GT tech4GT merged commit 611016b into publiclab:main Dec 28, 2018
@harshkhandeparkar harshkhandeparkar deleted the fix-gif-generation branch December 28, 2018 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tech4GT tech4GT tech4GT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GIF generation is not working correctly
2 participants
@harshkhandeparkar @tech4GT