Clarify that saved sequence will only be available in this browser

[Mridul97]

Fixes #573

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[Mridul97]

Screenshot :

cc @jywarren @tech4GT

[harshkhandeparkar]

@Mridul98, I think the message will look better if the ... at the end are removed. Also the fullstop can be removed or placed outside the ).

[Mridul97]

@harshkhandeparkar I think maybe ... is looking good. I agree the fullstop should be outside the bracket, will do that! Thanks!

[jywarren]

I could go either way on `...` - happy to defer to Mridul on this. I do think we should add "It will appear as a module in the Add Step menu" - so people know where to find it!

…

On Tue, Jan 1, 2019 at 2:43 PM Mridul97 ***@***.***> wrote: @harshkhandeparkar <https://github.com/HarshKhandeparkar> I think maybe ... is looking good. I agree the fullstop should be outside the bracket, will do that! Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#587 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJ7aagdYypbVKAylElKQFb2bkqN7Nks5u-7o-gaJpZM4Zl2f6> .

[Mridul97]

@jywarren I have added a message showing where the saved sequences can be found #586 here. Please have a look!

[jywarren]

Yes ok great! Super - then this looks good!

…

On Wed, Jan 2, 2019 at 4:37 AM Mridul97 ***@***.***> wrote: @jywarren <https://github.com/jywarren> I have added a message showing where the saved sequences can be found #586 <#586> here. Please have a look! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#587 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABfJyL0V0DcAaroxcgODwlFpUDbDitMks5u_H3BgaJpZM4Zl2f6> .

[harshkhandeparkar]

@Mridul97 you can use ternary operator for result.
result = result ? result + ' (local)' : null

[Mridul97]

@harshkhandeparkar we can do that but if is also doing the same thing and do you think it will work when the user leaves the textbox empty and clicks ok?

[harshkhandeparkar]

This was just a suggestion. Makes the code look cleaner.

[harshkhandeparkar]

Also something you could do is that save the sequence only if result is a non empty string else do nothing or window.prompt() something else.

[Mridul97]

Yes, I agree the code will look cleaner! I will try it out. Thanks!

[Mridul97]

Also something you could do is that save the sequence only if result is a non empty string else do nothing or window.prompt() something else.

Yes, the sequence is saved only when the string is non-empty, otherwise it is not saved!

[harshkhandeparkar]

Ok then NP!!

[harshkhandeparkar]

@harshkhandeparkar we can do that but if is also doing the same thing and do you think it will work when the user leaves the textbox empty and clicks ok?

Yes, it will work. it basically does the same thing but instead of running some code based on some logic, it returns some code if statement is true or returns something else if statement is false.

[Mridul97]

Great!

[Mridul97]

@harshkhandeparkar actually both the approaches were saving the sequence by the name of 'null' when the user clicked cancel button. But I have fixed this error!

[Mridul97]

@jywarren Please review this!

[jywarren]

Looks awesome. Great teamwork, folks!!!