Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header opens new page #600

Closed
wants to merge 1 commit into from
Closed

Header opens new page #600

wants to merge 1 commit into from

Conversation

aashna27
Copy link

@aashna27 aashna27 commented Jan 3, 2019

Fixes #568

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

@aashna27 aashna27 requested a review from jywarren January 3, 2019 19:14
@harshkhandeparkar
Copy link
Member

Will href="/" redirect to / instead of examples/ which is the required directory?

@aashna27
Copy link
Author

aashna27 commented Jan 3, 2019

no it will redirect to examples only

@harshkhandeparkar
Copy link
Member

Ok then NP. Sorry for disturbing.

@aashna27
Copy link
Author

aashna27 commented Jan 3, 2019

Ok then NP. Sorry for disturbing.

no not at all, happy to learn from you.

@publiclab publiclab deleted a comment from harshkhandeparkar Jan 3, 2019
@publiclab publiclab deleted a comment from harshkhandeparkar Jan 3, 2019
@publiclab publiclab deleted a comment from harshkhandeparkar Jan 3, 2019
@publiclab publiclab deleted a comment from harshkhandeparkar Jan 3, 2019
@aashna27 aashna27 closed this Jan 4, 2019
@aashna27 aashna27 deleted the header-new-page branch January 4, 2019 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jywarren jywarren Awaiting requested review from jywarren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aashna27 @harshkhandeparkar