Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added thumbnails to insert step preview #647

Closed
wants to merge 1 commit into from
Closed

Added thumbnails to insert step preview #647

wants to merge 1 commit into from

Conversation

Divy123
Copy link
Member

@Divy123 Divy123 commented Jan 10, 2019

Fixes #618

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@Divy123
Copy link
Member Author

Divy123 commented Jan 10, 2019

@jywarren please review.

@jywarren
Copy link
Member

Can you share a screenshot? Thanks!!!

@Divy123
Copy link
Member Author

Divy123 commented Jan 10, 2019

I am sorry . There are some errors I have recently seen. I will be opening a new PR soon enough.

@Divy123 Divy123 closed this Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants