-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map types to HtmlTypes #674
Map types to HtmlTypes #674
Conversation
@publiclab/is-reviewers please review. @jywarren I have added the function to |
My exams are going to start so I will not be available until 30th Jan. |
I have merged with main. @publiclab/is-reviewers please review. |
@Mridul97 I'm not able to require my MapHTMLTypes.js file due to code refactoring. Could you please help? |
Also I think it is not added to the watch task. Can you please do that? |
@harshkhandeparkar Yes, I will look into this! |
Thanks!
|
@publiclab/is-reviewers I have rebased. Please review. |
@jywarren @publiclab/is-reviewers conflicts resolved!! |
oh no, did you add more? |
i rebased... shall i wait? |
@jywarren you can go ahead. |
👍 great job! |
@jywarren when are you going to push to gh-pages btw? |
Oh wait. What happened to the pr? The changes? I cannot see any changes. Neither are the files added to the repo. @jywarren |
Fixes #570
Added a new function to
examples/lib
which mapstype
from module info.json files to valid HTML input types.Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!