Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map types to HtmlTypes #674

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Map types to HtmlTypes #674

merged 1 commit into from
Feb 8, 2019

Conversation

harshkhandeparkar
Copy link
Member

@harshkhandeparkar harshkhandeparkar commented Jan 15, 2019

Fixes #570

Added a new function to examples/lib which maps type from module info.json files to valid HTML input types.

new-func-channel

new-func-drawrectangle

new-func-rotate

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@harshkhandeparkar
Copy link
Member Author

@publiclab/is-reviewers please review. @jywarren I have added the function to examples/lib/ as it is not required by image-sequencer main library source.

@harshkhandeparkar
Copy link
Member Author

My exams are going to start so I will not be available until 30th Jan.

@harshkhandeparkar
Copy link
Member Author

I have merged with main. @publiclab/is-reviewers please review.

@harshkhandeparkar
Copy link
Member Author

@Mridul97 I'm not able to require my MapHTMLTypes.js file due to code refactoring. Could you please help?

@harshkhandeparkar
Copy link
Member Author

Also I think it is not added to the watch task. Can you please do that?

@Mridul97
Copy link

@harshkhandeparkar Yes, I will look into this!

@harshkhandeparkar
Copy link
Member Author

harshkhandeparkar commented Jan 23, 2019 via email

@harshkhandeparkar
Copy link
Member Author

@publiclab/is-reviewers I have rebased. Please review.

@harshkhandeparkar
Copy link
Member Author

@jywarren @publiclab/is-reviewers conflicts resolved!!

@jywarren
Copy link
Member

jywarren commented Feb 8, 2019

oh no, did you add more?

@jywarren
Copy link
Member

jywarren commented Feb 8, 2019

i rebased... shall i wait?

@harshkhandeparkar
Copy link
Member Author

@jywarren you can go ahead.

@jywarren jywarren merged commit 78cbaa2 into publiclab:main Feb 8, 2019
@jywarren
Copy link
Member

jywarren commented Feb 8, 2019

👍 great job!

@harshkhandeparkar
Copy link
Member Author

@jywarren when are you going to push to gh-pages btw?

@harshkhandeparkar
Copy link
Member Author

Oh wait. What happened to the pr? The changes? I cannot see any changes. Neither are the files added to the repo. @jywarren

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants