Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added New FlipImage Module #696

Merged
merged 8 commits into from
Mar 2, 2019
Merged

Added New FlipImage Module #696

merged 8 commits into from
Mar 2, 2019

Conversation

harshkhandeparkar
Copy link
Member

@harshkhandeparkar harshkhandeparkar commented Jan 22, 2019 •
edited
Loading

Fixes #[Add issue number here.]

This new module flips the image on the selected axis.

flip-img-module

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@harshkhandeparkar harshkhandeparkar changed the title Added New Flip Module Added New FlipImage Module Jan 22, 2019
@harshkhandeparkar
Copy link
Member Author

@publiclab/is-reviewers

@harshkhandeparkar harshkhandeparkar mentioned this pull request Jan 22, 2019
Open
@aashna27
Copy link

This is some really good work !! 🙌

Mridul97
Mridul97 requested changes Jan 22, 2019
View reviewed changes
Copy link

@Mridul97 Mridul97 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing! Well done!

src/modules/FlipImage/Module.js Outdated Show resolved Hide resolved
Mridul97
Mridul97 approved these changes Jan 22, 2019
View reviewed changes
Copy link

@Mridul97 Mridul97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great!

@vibhorgupta-gh vibhorgupta-gh mentioned this pull request Jan 24, 2019
Merged
4 tasks
@harshkhandeparkar
Copy link
Member Author

@publiclab/is-reviewers I have rebased. Please review.

jywarren
jywarren approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super! Great work, @harshkhandeparkar !!! Just needs a rebase and then we're good!

@harshkhandeparkar
Copy link
Member Author

@jywarren @publiclab/is-reviewers conflicts fixed!!

@jywarren
Copy link
Member

jywarren commented Feb 8, 2019

Hi, i tried a couple times to rebase this but got some conflicts. Perhaps you should try squashing the commits first and then rebasing? Oddly the conflicts were in the UI code, which you haven't touched here. Can you give it a try?

@harshkhandeparkar
Copy link
Member Author

@jywarren @publiclab/is-reviewers Merged with main!!

@harshkhandeparkar
Copy link
Member Author

@jywarren can you please merge my PRs before the other ones since I will not be able to touch my PC until 16th of april. I don't know if I will get time past that date as well.

tech4GT and others added 8 commits March 2, 2019 13:15
@tech4GT @jywarren
update dist
5d05130 
Signed-off-by: tech4GT <varun.gupta1798@gmail.com>

dist update

Revert "dist update"

This reverts commit 9ee2a98.
@jywarren
rebase and rebuild
170d9e5
@jywarren
add dist
c296928
@jywarren
flip image
88412cc
@harshkhandeparkar @jywarren
Changes
fb9aeda
@harshkhandeparkar @jywarren
Changes
f8c3399
@jywarren
add dist
fe3e20b
@jywarren
missed one
6589a8b
@jywarren
Copy link
Member

jywarren commented Mar 2, 2019

Whew, that was a tough rebase. Let's see how it does.

@jywarren jywarren merged commit ac57b32 into publiclab:main Mar 2, 2019
@jywarren
Copy link
Member

jywarren commented Mar 2, 2019

🎉

@harshkhandeparkar
Copy link
Member Author

Thanks!!!

@harshkhandeparkar harshkhandeparkar deleted the flip-module branch June 7, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aashna27 aashna27 aashna27 approved these changes

@Mridul97 Mridul97 Mridul97 approved these changes

@jywarren jywarren jywarren approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@harshkhandeparkar @aashna27 @jywarren @Mridul97 @tech4GT