-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Save As" overflow on small screens #795
Conversation
Thanks for opening this pull request! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!
@lohitha02 mention @publiclab/is-reviewers to make it review :) |
@lohitha02 Welcome and thanks for your PR. A few suggestions. Please link the issue in the PR body with the keyword Fixes as this will close the issue as soon as the PR is merged. Thanks! |
Next time please ask in the issue discussion if you can accept the issue. This will make sure that no two contributors will work on the same issue. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please commit the requested changes
examples/index.html
Outdated
@@ -1,4 +1,4 @@ | |||
<!DOCTYPE html> | |||
z<!DOCTYPE html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this
You can descriptively title the PR to make it easier for the reviewers to review it. Thanks! |
@lohitha02 jst make the changes said by @harshkhandeparkar and push it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but please provide a screenshot/GIF. Thanks!
@lohitha02 thanks for your contributions and we need more contributions from you 👍 |
@publiclab/reviewers please review this. |
@lohitha02 please mention @publiclab/is-reviewers |
This is super. Thank you so much, and thanks everyone for the helpful comments! |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Fixes #789
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/reviewers
and@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!