Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Save As" overflow on small screens #795

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Fix "Save As" overflow on small screens #795

merged 2 commits into from
Feb 21, 2019

Conversation

lohitha02
Copy link
Member

@lohitha02 lohitha02 commented Feb 18, 2019

Fixes #789

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers and @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@welcome
Copy link

welcome bot commented Feb 18, 2019

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@lohitha02
Copy link
Member Author

#789

Copy link

@harshithpabbati harshithpabbati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

@harshithpabbati
Copy link

@lohitha02 mention @publiclab/is-reviewers to make it review :)

@harshkhandeparkar
Copy link
Member

harshkhandeparkar commented Feb 18, 2019

@lohitha02 Welcome and thanks for your PR. A few suggestions. Please link the issue in the PR body with the keyword Fixes as this will close the issue as soon as the PR is merged. Thanks!

@harshkhandeparkar
Copy link
Member

Next time please ask in the issue discussion if you can accept the issue. This will make sure that no two contributors will work on the same issue. Thanks

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please commit the requested changes

@@ -1,4 +1,4 @@
<!DOCTYPE html>
z<!DOCTYPE html>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this

@harshkhandeparkar harshkhandeparkar changed the title Fixed #789 issue Fix "Save As" overflow on small screens Feb 18, 2019
@harshkhandeparkar
Copy link
Member

You can descriptively title the PR to make it easier for the reviewers to review it. Thanks!

@harshithpabbati
Copy link

@lohitha02 jst make the changes said by @harshkhandeparkar and push it again.
Thanks:)

Copy link
Member

@harshkhandeparkar harshkhandeparkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please provide a screenshot/GIF. Thanks!

@harshithpabbati
Copy link

@lohitha02 thanks for your contributions and we need more contributions from you 👍

@lohitha02
Copy link
Member Author

publiclab

@lohitha02
Copy link
Member Author

@publiclab/reviewers please review this.

@harshithpabbati
Copy link

@lohitha02 please mention @publiclab/is-reviewers
Thanks:)

@jywarren
Copy link
Member

This is super. Thank you so much, and thanks everyone for the helpful comments!

@jywarren jywarren merged commit 600ddec into publiclab:main Feb 21, 2019
@welcome
Copy link

welcome bot commented Feb 21, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://sequencer.publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants