The cursor changes to pointer when hovered over select element

[rohithGoudM]

Fixes #913

This is my first PR, so please let me know even if it is wrong.
I really want to contribute here (publiclab)
Any kind of reply would be greatly appreciated

Thanks!

[welcome]

Thanks for opening this pull request!
There may be some errors, but don't worry! We're here to help! 👍🎉😄

[harshkhandeparkar]

Ok you opened a pr. @publiclab/is-reviewers will review your pr.

[harshkhandeparkar]

Can you put the styles in examples/demo.css ?

[subhahu123]

@rohithGoudM can u provide a preview link
u can use github pages

[rohithGoudM]

Can you put the styles in examples/demo.css ?

Yes,
But I also want to know what should I do to get into publiclab for gsoc2019.

[harshkhandeparkar]

@rohithGoudM

Yes,
But I also want to know what should I do to get into publiclab for gsoc2019.

Nothing. Wait for this pr to be merged. You will get an invite to join publiclab and you can participate.

[harshkhandeparkar]

You should know the codebase well. You can solve a few issues and you will be well acquainted with the codebase. 😊. I don't know much about gsoc and the proposals etc. You can ask @gauravano @jywarren @tech4GT or other @publiclab/is-reviewers

[subhahu123]

Can you put the styles in examples/demo.css ?

Yes,
But I also want to know what should I do to get into publiclab for gsoc2019.

as far as i know ( i m also applying ) u should continue contributing to publiclab and select ur project u want to work on and prepare a propoal for that
Also u should know the codebase well as said by @harshkhandeparkar

[rohithGoudM]

Can you put the styles in examples/demo.css ?

Yes,
But I also want to know what should I do to get into publiclab for gsoc2019.

as far as i know ( i m also applying ) u should continue contributing to publiclab and select ur project u want to work on and prepare a propoal for that

I want to work on image-sequencer
I like the idea but how can i make any impression on publiclab's recruiting team

[subhahu123]

Can you put the styles in examples/demo.css ?

Yes,
But I also want to know what should I do to get into publiclab for gsoc2019.

as far as i know ( i m also applying ) u should continue contributing to publiclab and select ur project u want to work on and prepare a propoal for that

I want to work on image-sequencer
I like the idea but how can i make any impression on publiclab's recruiting team

ur contibution is only way to get an impression and then after ur proposal idea

[rohithGoudM]

Can you put the styles in examples/demo.css ?

Done.

[rohithGoudM]

Is my PR eligible for merging..?
Can I solve other issues that has first-timers-only issues..?
If not could you refer some issues here so I can try solving them..?

[subhahu123]

Is my PR eligible for merging..?
Can I solve other issues that has first-timers-only issues..?
If not could you refer some issues here so I can try solving them..?

#924
Try solve this one

[harshkhandeparkar]

You can solve any issue. I don't think there are any more First-Timers-Only issues left but there may be some which are marked as fto-candidate issues and also there are some with the label small. Also which field are you best in? Js/html/css? We can assign you issues based on that. If you are good with js, you can see check out some core library issues with the module label.

[rohithGoudM]

Is my PR eligible for merging..?
Can I solve other issues that has first-timers-only issues..?
If not could you refer some issues here so I can try solving them..?

#924
solve this one

ON it.

[rohithGoudM]

You can solve any issue. I don't think there are any more First-Timers-Only issues left but there may be some which are marked as fto-candidate issues and also there are some with the label small. Also which field are you best in? Js/html/css? We can assign you issues based on that. Of you are good with js, you can see check out some core library issues with the module label.

I have a little background in js through node js. Also happy to help with html and css.

[harshkhandeparkar]

@subhahu123 is this ready to merge? Have you checked out the changes locally?

[subhahu123]

@subhahu123 is this ready to merge? Have you checked out the changes locally?

i have not checked this locally

[subhahu123]

@harshkhandeparkar
what are the changes in package.json
it was not required

[subhahu123]

i have just notice this

[subhahu123]

moreover he has to squash his commit also
@harshkhandeparkar

[harshkhandeparkar]

I can see that the dist files have been changed directly. Please make the appropriate changes to the src files in examples/lib directory as well.

[rohithGoudM]

@harshkhandeparkar
what are the changes in package.json
it was not required

those changes were in package-lock.json not in package.json,
I didn't know if those changes were useful.

[harshkhandeparkar]

No need to squash commits. They are squashed while merging.

[subhahu123]

No need to squash commits. They are squashed while merging.

Ok

[rohithGoudM]

I can see that the dist files have been changed directly. Please make the appropriate changes to the src files in examples/lib directory as well.

I have added the class to examples/lib files too

[subhahu123]

I can see that the dist files have been changed directly. Please make the appropriate changes to the src files in examples/lib directory as well.

I have added the class to examples/lib files too

where there is a change in package.json

[rohithGoudM]

I have added the class to examples/lib files too

where there is a change in package.json

I didn't get you exactly.

[subhahu123]

I have added the class to examples/lib files too

where there is a change in package.json

I didn't get you exactly.

what changes u have done in package.json
i was not required u should remove it
@rohithGoudM

[aashna27]

"csrtoptr" can the class name be made a little more descriptive ??

[grvsachdeva]

hey @rohithGoudM, you need any help finishing this one? Thanks!

[harshkhandeparkar]

This has been fixed already.