forked from jywarren/image-sequencer
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid-Overlay module. #974
Merged
Merged
Grid-Overlay module. #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jywarren This is a new module which overlays grid over the image. |
@jywarren @publiclab/is-reviewers have a look at this. |
This is so nice!!! Is there a parameter we could use to set the grid square
size? Thank you!!!
…On Tue, Apr 2, 2019 at 10:59 AM Harshith pabbati ***@***.***> wrote:
@jywarren <https://github.com/jywarren> @publiclab/is-reviewers
<https://github.com/orgs/publiclab/teams/is-reviewers> have a look at
this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#974 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ7O62F223ZvfO2-7m7yPPc7o4o6Eks5vc3AugaJpZM4cX2I6>
.
|
Yeah I guess can do it. I will make it and update it. |
Divy123
reviewed
Apr 2, 2019
|
jywarren
approved these changes
Apr 3, 2019
This is really nice!!!!!! Thanks! |
Do I need to write the doc for the module ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #[Add issue number here.]
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!