Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid-Overlay module. #974

Merged
merged 3 commits into from
Apr 3, 2019
Merged

Grid-Overlay module. #974

merged 3 commits into from
Apr 3, 2019

Conversation

harshithpabbati
Copy link

Fixes #[Add issue number here.]

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@harshithpabbati
Copy link
Author

@jywarren This is a new module which overlays grid over the image.
grid

@harshithpabbati
Copy link
Author

@jywarren @publiclab/is-reviewers have a look at this.

@jywarren
Copy link
Member

jywarren commented Apr 2, 2019 via email

@harshithpabbati
Copy link
Author

Yeah I guess can do it. I will make it and update it.

@harshithpabbati
Copy link
Author

gridover
@jywarren Done with adding the x and y as inputs.

@jywarren jywarren merged commit 0e7323e into publiclab:main Apr 3, 2019
@jywarren
Copy link
Member

jywarren commented Apr 3, 2019

This is really nice!!!!!! Thanks!

@harshithpabbati
Copy link
Author

Do I need to write the doc for the module ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants