Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added code of conduct from Public Lab Github link to the created file CODE_OF_CONDUCT.md #53

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rizsyed1
Copy link
Contributor

…_CONDUCT.md ... Unfortunately I could only safe the file in a txt format, and so it is not possible to display the Dos and Donts in the table (as rendered on the Public Lab Github link on the issue page).

If there are any issues with this pull request, please do let me know and I will make the appropriate edits.

Thanks,
Riz :)

…_CONDUCT.md ... Unfortunately I could only safe the file in a txt format, and so it is not possible to display the Dos and Donts in the table (as rendered on the Public Lab Github link on the issue page).
@grvsachdeva
Copy link
Member

Hi @RizwanSyed357, please mention the issue you are solving here. Also, you have only copied the text of Code of Conduct file, you are required to copy the whole markdown. You can do that by going at the link and opening the code in raw mode and then copy the file and paste here. If you have any questions, feel free to ask. Thanks!

@rizsyed1
Copy link
Contributor Author

Hi @gauravano , thanks for that. I have never done this before.

I will apply your feedback and make another pull request shortly, and I will explain the problem I am trying to solve in the accompanying pull request message

@grvsachdeva
Copy link
Member

You don't have to open a new PR, you can make change in this one only.

…ut this time from the raw coge on the Github page.
@rizsyed1
Copy link
Contributor Author

Hi, thanks for that. I have pushed the file with the raw code pasted into it, to the forked repo.

Is there anything else I need to do now?

@@ -0,0 +1,113 @@
This document was copied from its home at https://publiclab.org/conduct on October 12, 2017. See that page if you would like to submit your concerns in a safe, completely anonymous way, and to learn more about this document.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the date to current.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gauravano would you like me to do that?

Sorry - I thought about doing that but decided to stick to the instructions in case that wasn't what you wanted.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it wasn't mentioned in the instructions. I hope, it's fine with you?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - yes sure, that is fine. I have changed the date and pushed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @RizwanSyed357!

@rizsyed1
Copy link
Contributor Author

Hi all. @jywarren it would be great to have some idea about when you might be able to approve this, if that is ok? Looking forward to seeing this commit on my profile :) . Cheers!

@grvsachdeva
Copy link
Member

hey @RizwanSyed357, sorry for the delay here. I just asked another contributor to finish-up the remaining work publiclab/plots2#4730 (comment).

@grvsachdeva grvsachdeva closed this Apr 3, 2019
@grvsachdeva grvsachdeva reopened this Apr 3, 2019
@grvsachdeva
Copy link
Member

Oops! closed this one by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants