Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add google api stub for geocoder #93

Closed
wants to merge 2 commits into from
Closed

Add google api stub for geocoder #93

wants to merge 2 commits into from

Conversation

nstjean
Copy link
Contributor

@nstjean nstjean commented Jan 20, 2020

This solves the errors when it tried to bump LBL to 1.6.0 in #92

@welcome
Copy link

welcome bot commented Jan 20, 2020

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@nstjean nstjean mentioned this pull request Jan 21, 2020
Closed
@nstjean nstjean mentioned this pull request Jan 21, 2020
Closed
sagarpreet-chadha
sagarpreet-chadha approved these changes Jan 21, 2020
View reviewed changes
Copy link
Collaborator

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!!!
I wonder why it was working before? I think @jywarren restricted access to that google API recently or maybe google API got changed something.
Thanks!

@nstjean
Copy link
Contributor Author

nstjean commented Jan 21, 2020

In LBL 1.6.0 the API got changed (by me) to the client-side version rather than the server-side version. There were no issues with the pages running, but it's causing a mess with the tests!

@nstjean
Copy link
Contributor Author

nstjean commented Jan 21, 2020

This may not be necessary anymore, see my comments on publiclab/leaflet-blurred-location#235 (comment)

@jywarren
Copy link
Member

Should we merge it anyways? Or hold off?

@nstjean
Copy link
Contributor Author

nstjean commented Jan 21, 2020

I'd like to hold off and merge in the bumped LBL with change and see what happens.

@nstjean
Copy link
Contributor Author

nstjean commented Jan 28, 2020

This is solved in #95

@nstjean nstjean closed this Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagarpreet-chadha sagarpreet-chadha sagarpreet-chadha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nstjean @jywarren @sagarpreet-chadha