Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor api fix #185

Merged
merged 1 commit into from
Feb 20, 2019
Merged

minor api fix #185

merged 1 commit into from
Feb 20, 2019

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Feb 20, 2019

Closes #184. @jywarren, I've been stuck at #182 (comment) for a while now, maybe missing something obvious? Do you have a minute to provide some input on it? Thanks!!

PS. #184 was caused by a logical error. Used the same API key from here, works fine.

var url = "https://maps.googleapis.com/maps/api/geocode/json?address=" + string.split(" ").join("+") + "&key=AIzaSyDWgc7p4WWFsO3y0MTe50vF4l4NUPcPuwE" ;

@rexagod
Copy link
Member Author

rexagod commented Feb 20, 2019

peek 2019-02-21 01-15

@jywarren
Copy link
Member

Oh that's great, thank you! Yes, i'll take a look. Great fix, and so fast! 🏃

@jywarren jywarren merged commit 5174403 into publiclab:main Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants