Add error checking to geocodeStringAndPan #220
Conversation
src/core/Geocoding.js
Outdated
| map.setView([geometry.lat, geometry.lng], options.zoom); | ||
| onComplete = onComplete || function onComplete(response) { | ||
| if(response.status === "OK") { | ||
| let geometry = response.results[0].geometry.location; |
There was a problem hiding this comment.
This is what's causing the tests to fail. I've looked for any other instance that is calling this function and why it might be throwing errors but I can't see anything. It's only the tests, for some reason this is causing the tests to not build the BlurredLocation object.
|
Fixed the testing errors by removing the offending line, it did not want me referring the the results in a variable. Using |
|
Hi @nstjean, sorry just seeing this just now...rebase should fix this. |
|
Ok, I'll try running that and see what I get! |
nstjean
force-pushed
the
geocode-string-and-pan-error
branch
from
96bfcfb
to
7a0985d
Compare
|
I think I did it!! I don't know what the rebase did to |
|
Ah, hm, it still seems out of date, but GitHub is indicating it can resolve the conflict so it must be pretty simple.
Does this have the /dist/ changes in it, so if we press "update branch" it should be merge-able? Thanks! |
nstjean
force-pushed
the
geocode-string-and-pan-error
branch
from
7a0985d
to
12b3318
Compare
|
Ok updated /dist/ |
package.json
Outdated
| @@ -35,6 +35,7 @@ | |||
| "resig-class": "^1.0.0" | |||
| }, | |||
| "dependencies": { | |||
| "grunt-cli": "^1.3.2", | |||
There was a problem hiding this comment.
Ah, i think this may need to be in "dev-dependencies" so that it only gets included for developers, not for deployment? not a big deal but good practice. Thank you! https://docs.npmjs.com/specifying-dependencies-and-devdependencies-in-a-package-json-file
There was a problem hiding this comment.
Oh that's interesting. I installed it and didn't realize it would get added in there. I'll move it to dev-dependencies!
|
@jywarren This should be all set! Hopefully! |
|
|
||
| map.setView([geometry.lat, geometry.lng], options.zoom); | ||
| onComplete = onComplete || function onComplete(response) { | ||
| if(response.status === "OK") { |
There was a problem hiding this comment.
Hey @nstjean , awesome!
Do we have response.code === 200? Thanks!
There was a problem hiding this comment.
Oh you mean in addition to the response.status from google we should also check the http response code?
There was a problem hiding this comment.
Yes usually i have seen people checking code but i guess status also works fine!
|
🎉 |
Fixes #214
Prevent hanging when user uses the location autocomplete search if the call returns an error.
Trying this PR again, last branch I think was just too mixed up.