Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tile layer to options #228

Merged
merged 5 commits into from
Jan 2, 2020
Merged

Add tile layer to options #228

merged 5 commits into from
Jan 2, 2020

Conversation

cesswairimu
Copy link
Contributor

@cesswairimu cesswairimu commented Dec 24, 2019 •
edited
Loading

Allow tile layer link to options to be used when initializing map as options.tileLayerUrl

@welcome
Copy link

welcome bot commented Dec 24, 2019

Thanks for opening this pull request! Dangerbot will test out your code and reply in a bit with some pointers and requests.
There may be some errors, but don't worry! We're here to help! 👍🎉😄

@cesswairimu
Copy link
Contributor Author

cesswairimu commented Dec 24, 2019 •
edited
Loading

examples/bluish.html template

layers

jywarren
jywarren approved these changes Dec 24, 2019
View reviewed changes
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome. Let's bump the npm version by 0.1.0!

@cesswairimu cesswairimu force-pushed the change-tile branch 3 times, most recently from 0774d39 to 20ccd89 Compare December 24, 2019 19:29
@cesswairimu
Copy link
Contributor Author

Done...Thanks @jywarren

sagarpreet-chadha
sagarpreet-chadha approved these changes Dec 25, 2019
View reviewed changes
Copy link
Collaborator

@sagarpreet-chadha sagarpreet-chadha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!!

@cesswairimu
Copy link
Contributor Author

Could someone please merge this one for me...Thanks

@cesswairimu cesswairimu mentioned this pull request Jan 1, 2020
Merged
5 tasks
@jywarren jywarren merged commit 550b8ac into main Jan 2, 2020
@jywarren
Copy link
Member

jywarren commented Jan 2, 2020

👍

@welcome
Copy link

welcome bot commented Jan 2, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to https://publiclab.org in the next few days.
In the meantime, can you tell us your Twitter handle so we can thank you properly?
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

@cesswairimu
Copy link
Contributor Author

Thanks

@cesswairimu
Copy link
Contributor Author

Happy new year @jywarren 👋 , could you please publish this version when you get a sec? Thanks

@jywarren
Copy link
Member

jywarren commented Jan 2, 2020

Yes!! Happy new year to you too! 🎉 🍾

@jywarren
Copy link
Member

jywarren commented Jan 2, 2020

Done!

@jywarren
Copy link
Member

jywarren commented Jan 2, 2020

v1.5.1

@cesswairimu
Copy link
Contributor Author

Great... Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nstjean nstjean nstjean approved these changes

@sagarpreet-chadha sagarpreet-chadha sagarpreet-chadha approved these changes

@jywarren jywarren jywarren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cesswairimu @jywarren @sagarpreet-chadha @nstjean