Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone demo page with embed pointing to the actual page #311

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

crisner
Copy link
Contributor

@crisner crisner commented Dec 18, 2019

Fixes #310 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@crisner
Copy link
Contributor Author

crisner commented Dec 18, 2019

  • Cloned index.html to embed.html
  • Removed notice from showing in index.html
  • Added notice to appear only on embed.html
  • Embed code in embed.html points to //publiclab.github.io/leaflet-environmental-layers/example/index.html
Screenshot of embed page with embed code:

embed-demo

@crisner
Copy link
Contributor Author

crisner commented Dec 18, 2019

@jywarren, could you take a look at this to see if I got this right?

@jywarren
Copy link
Member

Looks perfect!

@jywarren jywarren merged commit 5c072fb into publiclab:master Dec 18, 2019
@jywarren
Copy link
Member

Thanks a ton!!!!!

@crisner
Copy link
Contributor Author

crisner commented Dec 18, 2019

🎉 😃

@sagarpreet-chadha
Copy link
Collaborator

Awesome!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clone demo page to embed.html so that actual embeds do not show the notice
3 participants