Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for embed feature #314

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

crisner
Copy link
Contributor

@crisner crisner commented Dec 20, 2019

Fixes #313 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@crisner
Copy link
Contributor Author

crisner commented Dec 20, 2019

I have added some tests for the embed feature. I struggled a bit with this one as I am not used to writing tests. Looking forward to feedback.

Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! One way to be extra confident in tests is to break them intentionally, and see if correct and useful errors result. Especially in Travis, where we'll be seeing them in the future! This looks good to merge but if you'd like to try breaking the tests to confirm they will report in Travis, go ahead and we can revert and merge after!

@crisner
Copy link
Contributor Author

crisner commented Dec 20, 2019

Great! I'll try breaking the tests to confirm how it reports on Travis.

@crisner
Copy link
Contributor Author

crisner commented Dec 20, 2019

I did as you suggested and Travis does report the errors when I push broken code. 🎉 :D

@sagarpreet-chadha sagarpreet-chadha merged commit ca6c0a6 into publiclab:master Dec 20, 2019
@sagarpreet-chadha
Copy link
Collaborator

Awesome!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write tests for embed feature
3 participants