Test layers browser with grunt jasmine #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jywarren, @sagarpreet-chadha, could you help me figure out why tests are failing in travis? Am I doing something wrong in travis.yml or am I not registering the tasks as I should in gruntfile? When I run
|
|
@jywarren, updated node version did the trick! 🎉 |
crisner
changed the title
|
Oh, that's awesome!!! Super! Is this ready for merge then? |
|
Not yet. I may need to write a few more tests. I'll mention the PR in the Outreachy planning issue when it is ready. Thanks! |
|
ok, awesome! Great work!
…On Fri, Jan 3, 2020 at 12:46 PM Renisha Christie. A < ***@***.***> wrote:
Not yet. I may need to write a few more tests. I'll mention the PR in the
Outreachy planning issue when it is ready. Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#329?email_source=notifications&email_token=AAAF6J5CK5ZTGFM5SOUK6ADQ352EJA5CNFSM4KCNUBJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIBVLFQ#issuecomment-570643862>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAF6JZPABPRRN6H7WJH6TTQ352EJANCNFSM4KCNUBJQ>
.
|
crisner
changed the title
|
@jywarren, this PR is ready for merge. :) |
|
Awesome!!!! |
|
This is Awesome!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!