Display new items mark in layers menu #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The badge shows the number of new layers available for the user to access when the user enters specific bounds or zoom in the map view. It also reduces the number displayed when the user moves out of it without checking the layers menu. The badge becomes hidden when the user has checked the layers menu or the user is no longer in the map view of the new layers. I checked the badge on smaller devices and it seems to be responsive. The number shows the number of layers without grouping them. For example, Justicemap layer group has 9 layers. I was wondering if I should just count the group instead of separate layers in the group. I would like some inputs on this. |
|
I will add a gif soon. Looks like the one I just recorded is too large. |
|
|
|
|
|
This is really great!
I think the full # is ok! |
|
Great, is this ready to merge? Thank you!!! |
|
Yes :) |
sagarpreet-chadha
added a commit
that referenced
this pull request
Mar 25, 2020
* Remove use of hardcoded extents for displaying layers (#332) * Fix embed code with duplicated text (#340) * Fix duplication of text in embed code * Update build file * Update README.md (#335) * Update README.md * Update README.md * Add check that layers group is not undefined when creating layers-sub-list (#339) Fixes #333 * Display new items mark in layers menu (#341) * Create function to check for available layers * Display badge to show new items * Save map instance in a variable * Update readme * Add contribute button to open infra map * Add media queries for size 235x300 (#346) * Add default basemap when undefined (#351) * Add default basemap when undefined * Update version number indicating bug-fix * [WIP] Add layers in include to map by default (#352) * Add unearthing layer to demo * Fix bug with removing points from the map on removeLayer * Add all layers in include param upon map initialization * bump to v2.1.9 * Implement new menu * Add new menu dependancies * Fix styles from overriding default leaflet classes * Refactor code * Fix styles for layer group name and layer description * Add option to disable layer visibility when param.include is true * Add option to use default layer control * Fix errors when trying to display layer when out of bounds * Add missing viewport meta tag * Move styles to LeafletEnvironmentalLayers.css * Update documentation * Add missing dependencies and update build * Fix error from unearthing layer on page reload * Set addLayersToMap options from param * Update documentation * Update AllLayers.js (#366) Fixed: Prevent use of the same default tile layer for multiple maps * Add PLpeopleLayer (#361) * add PLpeopleLayer to maps * fix function name to PLpeopleLayer * fix capital in function name * make naming consistent for both map examples * change layer name to PLpeople * version 2.2.0 and bump LBL to 1.7.0 (#368) * Feature/minimal mode (#356) * Create toggle mode control * Add marker for minimal mode * Change markers on mode change * Add condition and marker styles for eonet fires layer * Add minimal mode content to layers in layercode * Add minimal mode content to aqicn layer * Add minimal mode option * Refactor minimalMode control * Add mode control to one liner code * Add documentation to readme * Fix duplication of layers control, set simple layer control for demo * Add basic tests * Update build * 2.2.0 * Change button names and title * Update tests for mode control * Update build * Add demo with multiple maps in a single page * Add a check for jQuery and update build * Bug/fix missing layers in layer menu on refresh (#375) * Fix 'moveend' event check to affect only when removing layers from map * Add a check when adding minimal markers to confirm this._map exists * Update build * fix conflict * add parameter display to turn on layers * check if layer exists before turning it on * Remove conditions and code responsible for jquery duplication * Update link to jquery 3.3.1 and remove references to older versions * Move info.json outside iife and update build * Install cypress * published * Bug/fix layers not removed from map when hash false (#380) * Add error handling on removing unearthing from map * Remove redundant code * Comment out unused baselayer instantiation and update build * Uncomment baselayers * Reformat init defaults (#396) * rewrite init defaults * remove console.log * use L.Util.setOptions to set defaults * Add Cypress * Add tests to check leaflet left controls * Add tests for embed prompt and layers menu * Add child window to prevent iframe conflict on hash change * Add test to check hash update on map movement * Move hash test to a seperate file and increase delay * Set up http server for localhost * Ignore cypress screenshot and video folders * Set up cypress in travis * Oneliner/basic implementation tests (#397) * testing all the specs * using babel * add layer name id to broswer menu * leaflet not fully loading * recent tests * testing error in multiple maps * rewrite init defaults * basic one liner tests work * test shorter transpile files * emove jquery from gruntfile browserify dist * use L.Util.setOptions to set defaults * turn on basic tests again * disable babel-plugin-transform-object-rest-spread * clean up * rebase * add wisconsin layer back in and fix error * remove text-table files * add css file back in * fix merge errors * Edit and update documentation for more clarity (#367) * Add dependencies to documentation * Add updated documentation to readme * Add more information * Edit usage example for layer menu * Added links to more information * Update minimal mode documentation * Add files via upload * added a layerData folder containing the json file for sea level rise data Co-authored-by: Renisha Christie. A <29401459+crisner@users.noreply.github.com> Co-authored-by: Suyash Choudhary <57896905+sssash18@users.noreply.github.com> Co-authored-by: llabake <lemboyelabake@gmail.com> Co-authored-by: crisner <christie.reni@gmail.com> Co-authored-by: Sagarpreet Chadha <chadha.sagarpreet97@gmail.com> Co-authored-by: jywarren <jeff@unterbahn.com> Co-authored-by: z-arnott <50159450+z-arnott@users.noreply.github.com> Co-authored-by: Natalie St Jean <49460529+nstjean@users.noreply.github.com> Co-authored-by: Natalie <natalie.stjean@gmail.com> Co-authored-by: Cess <cessmbuguar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #133 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!