Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test mock for google api geocoder #358

Closed
wants to merge 1 commit into from
Closed

Add test mock for google api geocoder #358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Gruntfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ module.exports = function(grunt) {
],
options: {
specs: "spec/javascripts/*spec.js",
helpers: "spec/helpers/*.js",
vendor: [
'node_modules/jquery/dist/jquery.js',
'node_modules/jasmine-jquery/lib/jasmine-jquery.js',
Expand Down
4 changes: 3 additions & 1 deletion _SpecRunner.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<head>
<meta charset="utf-8">
<title>Jasmine Spec Runner</title>
<link rel="shortcut icon" type="image/png" href=".grunt\grunt-contrib-jasmine\jasmine_favicon.png">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be generated on run-time ideally, but let it be there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird that it changed that line, I didn't touch that file. I don't think this file exists in LBLD, I wonder if it's actually using it at all? The jasmine.json file existed but was totally ignored by Jasmine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I was right... I can delete that file and it doesn't affect the tests at all. It is being generated at runtime.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which is to say, it gets re-generated at runtime.

<link rel="shortcut icon" type="image/png" href=".grunt/grunt-contrib-jasmine/jasmine_favicon.png">

<link rel="stylesheet" type="text/css" href=".grunt/grunt-contrib-jasmine/jasmine.css">

Expand Down Expand Up @@ -32,6 +32,8 @@

<script src="node_modules/leaflet-blurred-location-display/dist/Leaflet.BlurredLocationDisplay.js"></script>

<script src="spec/helpers/google_mock.js"></script>

<script src="dist/LeafletEnvironmentalLayers.js"></script>

<script src="src/util/embedControl.js"></script>
Expand Down
Loading