Adding search control to LEL's basic usage #370
Conversation
|
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. |
| map.setView( [loc.lat(), loc.lng()], 18); | ||
| } | ||
| }).addTo(map); | ||
|
|
package.json
Outdated
| "author": { | ||
| "name": "Sagarpreet Chadha" | ||
| }, | ||
| "author": "Sagarpreet Chadha", |
There was a problem hiding this comment.
Let's remove these changes from here as it is not part of this issue. Please make a new issue for this. Thanks!
| @@ -953,7 +953,7 @@ | |||
| "JSONStream": { | |||
| "version": "1.3.5", | |||
| "resolved": "https://registry.npmjs.org/JSONStream/-/JSONStream-1.3.5.tgz", | |||
| "integrity": "sha1-MgjB8I06TZkmGrZPkjArwV4RHKA=", | |||
| "integrity": "sha512-E+iruNOY8VV9s4JEbe1aNEm6MiszPRr/UfcHMz0TQh1BXSxHK+ASV1R6W4HpjBhSeS+54PIsAMCBmwD06LLsqQ==", | |||
There was a problem hiding this comment.
@neelesh17, was this generated after running npm install?
@jywarren, I am not sure about this file. I would like your input here. Do we keep this change? Thanks!
|
@crisner I forgot to build the code in the first commit.I thinks thats why the problem you mentioned happened.Please review? |
|
@neelesh17, this PR is good for a merge once you make the changes requested. The changes in the code should be only in oneLinerCodeExample.html, unearthing-pvd.html, AllLayers.js and if you are running the build LeafletEnvironmentalLayers.js. Thanks! |
|
Also, I see you have named the branch as 'test'. It is good practice to name the branch descriptive of the task you are performing. Do let me know if you need any help. 😃 |
|
do i need to make changes in the packagelock.json file too? |
|
@sagarpreet-chadha, could you take a look at this when you are available? Thanks! 😃 |
|
@neelesh17, I see that you had closed this PR. Would you like to give it a go again? But as I mentioned in the other issue, if you are comfortable you could try other help wanted issues. Thanks! 😄 |
Fixes #369 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!