Add display parameter to show specific layers #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisner
approved these changes
Feb 1, 2020
| currentHash: location.hash, | ||
| addLayersToMap: false, | ||
| addLayersToMap: false, // activates layers on map by default if true. |
There was a problem hiding this comment.
Thanks for catching this! 😃
|
|
||
| if (!!this.options.addLayersToMap) { // turn on all layers | ||
| for (let layer of this.options.layers.include) { | ||
| map.addLayer(this.overlayMaps[layer]); |
| for (let layer of this.options.layers.display) { | ||
| // make sure the layer exists in the display list | ||
| if (this.options.layers.include.includes(layer)) { | ||
| map.addLayer(this.overlayMaps[layer]); |
| if (this.options.layers.include.includes(layer)) { | ||
| map.addLayer(this.overlayMaps[layer]); | ||
| } else { | ||
| console.log("Layer specified does not exist."); |
There was a problem hiding this comment.
Thanks for adding in the error handling too! 😄
|
Everything looks good to me. @sagarpreet-chadha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #377 (<=== Add issue number here)
There are cases in plots2 where we can't use a url hash to enable layers to be displayed. This param is optional and defaults to no layers being displayed on page load.
include: ['layername']will still limit what maps are available in the menudisplay: ['layername']will turn on the specified layers, if they are availableaddLayersToMap: truewill override and display all layers that are available, regardless of what is indisplay