Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight new layers #428

Merged
merged 11 commits into from
Mar 6, 2020
Merged

Conversation

crisner
Copy link
Contributor

@crisner crisner commented Mar 2, 2020

Fixes #427 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@crisner
Copy link
Contributor Author

crisner commented Mar 2, 2020

Screenshot of the feature:

Index page:

image

Onelinercode example page:

image

@crisner crisner changed the title Feature/highlight new layers Highlight new layers Mar 2, 2020
Copy link
Member

@jywarren jywarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Maybe sometime we'd make them fade away, but this is awesome as-is too. Thanks!!!

@jywarren
Copy link
Member

jywarren commented Mar 3, 2020

Just needs a rebase! Thank you!!!!

@crisner crisner added ready and removed needs-rebase labels Mar 4, 2020
@crisner
Copy link
Contributor Author

crisner commented Mar 4, 2020

@jywarren and @sagarpreet-chadha, I have fixed some inconsistencies in my latest commits here. This PR is ready to be merged after the commits are reviewed. Thanks!

@crisner crisner mentioned this pull request Mar 4, 2020
5 tasks
@crisner
Copy link
Contributor Author

crisner commented Mar 6, 2020

Fixed layer highlight working only on one map because of conflict in layer ids.
image

@jywarren
Copy link
Member

jywarren commented Mar 6, 2020

Awesome work here!!!! Merging!

@jywarren jywarren merged commit f56b6d1 into publiclab:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight new layers in the layer menu
2 participants