Layers browser width calculated based on map width #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this work with browser resizing too as media queries does? |
crisner
reviewed
Mar 3, 2020
src/util/mapResize.js
Outdated
| @@ -0,0 +1,33 @@ | |||
| // set the map menu to the correct size | |||
There was a problem hiding this comment.
Whoops forgot to remove that. I ended up not using it.
Yes, as long as the map size changes then the menu will adjust its size. |
|
I am curious. Does the map have to resize for it to take effect? Would it work as expected on smaller screens? |
|
No resize is needed, the function is called on load. Phone size: And here's ipad size on example/index.html: |
|
Awesome!!! 🎉 |
jywarren
approved these changes
Mar 3, 2020
nstjean
force-pushed
the
layers-browser-width
branch
from
d1d7937
to
541d225
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #420 (<=== Add issue number here)
I've reformatted the styling of the menus as they shrink down in size so that the menu style applied is calculated based on the size of the map itself, not the browser window. This is done by dynamically adding a class to the
.leaflet-containerWidth 0-379px gets "xs"
width 380-589px gets "sm"
width 590-879px gets "md"
width 880+ gets "lg"
Unfortunately the width of the menu itself is a set width for each of the classes, as using a % width doesn't work correctly and it would take me more time to figure out a solution. But I think this offers a pretty reasonable experience at any map width!
lgmdsmxsMake sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!