Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverting old versions doesn't work! #1298

Open
jywarren opened this issue May 12, 2020 · 7 comments
Open

Reverting old versions doesn't work! #1298

jywarren opened this issue May 12, 2020 · 7 comments

Comments

@jywarren
Copy link
Member

Clicking revert on this map: https://mapknitter.org/maps/pvdtest/edit

here:

image

leads to: https://mapknitter.org/images/revert?id=312456&version=760691

This seems like a routing error, though, since it's a 404. I hope so!

@jywarren
Copy link
Member Author

Aha this routing error didn't trip tests because they were functional tests!

@divyabaid16 would you have any time to take a look at routes and help us get your work back online? Thank you!

jywarren added a commit that referenced this issue May 19, 2020
@jywarren
Copy link
Member Author

Attempted fix in d6189a6 ... i think it was routes ordering?

@jywarren
Copy link
Member Author

@jywarren
Copy link
Member Author

We'll need a local install to fix this...

@jywarren
Copy link
Member Author

Hi @cesswairimu - i'm wondering if you have time in your hours to take a look at some of this to see if it's a relatively easy fix? Tell me what you think!

@cesswairimu
Copy link
Collaborator

sure thing, I will take a look within the week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants