Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage #467

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Increase test coverage #467

merged 1 commit into from
Apr 4, 2019

Conversation

kaustubh-nair
Copy link
Member

@kaustubh-nair kaustubh-nair commented Mar 31, 2019 •
edited
Loading

Part of #304

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

kaustubh-nair
kaustubh-nair commented Mar 31, 2019
View reviewed changes
app/controllers/comments_controller.rb
if logged_in? && current_user.can_edit?(@comment)
Comment.update(@comment.id, :body => params[:comment][:body])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was not updating the comment and the tests were failing. That's why I had to change it

@kaustubh-nair
Copy link
Member Author

@jywarren I just noticed the repo_token for coveralls is not loading. I wonder why that's happening?
It is working for some prs like this #462
but not for some 🤔

@kaustubh-nair
Copy link
Member Author

Looks like the token is loading for push builds but not for pr builds

@kaustubh-nair kaustubh-nair changed the title Add tests for comments controller Increase test coverage Apr 1, 2019
@kaustubh-nair
Copy link
Member Author

Added some more tests..

@kaustubh-nair
Copy link
Member Author

Hey @jywarren , please review this!
Thanks!

@jywarren
Copy link
Member

jywarren commented Apr 1, 2019

Hmm, i don't know -- and what's going on with Travis tests here? Are they stuck? They had some issues at Travis last week i think... could it be related?

@jywarren
Copy link
Member

jywarren commented Apr 1, 2019

And... thank you!

@kaustubh-nair
Copy link
Member Author

The problem is that travis does not expose environment variables for pull requests from external repositories. You can read about it here https://docs.travis-ci.com/user/pull-requests#pull-requests-and-security-restrictions
This is a really restricting constraint. I'm trying to find a good workaround for this.

@kaustubh-nair
Copy link
Member Author

The simplest way would be the make the REPO_TOKEN env variable public. But someone else can use it to send test coverage reports to coveralls. So I guess we can eliminate this approach?

@kaustubh-nair
Copy link
Member Author

But their security concern also makes sense.
If an external pr has access to the environment variable, they could just send some malicious code that could print the variable out. So giving external prs access to environment variables is essentially the same as making it public. We might as well put the environment variable in our repository then?
Thoughts? @jywarren

@jywarren
Copy link
Member

jywarren commented Apr 2, 2019 via email

@kaustubh-nair
Copy link
Member Author

Is it working for plots2?
I just checked some recent pr builds and it looks like travis isn't sending coverage report for those prs
Like for example
https://travis-ci.org/publiclab/plots2/builds/512970864#L3498
and https://travis-ci.org/publiclab/plots2/builds/514791356#L4206
It works for internal prs like this one though
https://travis-ci.org/publiclab/plots2/builds/511213184#L3486

@kaustubh-nair
Copy link
Member Author

Coverage reports on coveralls are mostly for push builds.
Not for pull requests I think

@kaustubh-nair kaustubh-nair reopened this Apr 2, 2019
@sashadev-sky sashadev-sky mentioned this pull request Apr 3, 2019
Closed
5 tasks
@kaustubh-nair
Copy link
Member Author

@jywarren If you think the tests are fine then should we merge this? I'll send more tests in subsequent prs.

@kaustubh-nair
Copy link
Member Author

And what should be done about the travis issue?
Should I open a new issue to discuss it there?

@jywarren
Copy link
Member

jywarren commented Apr 4, 2019

Yes, let's do! Thank you. And yes i'll merge this. Thanks so much! Heads up @cesswairimu who is also looking at improving testing (to coordinate!)

@jywarren jywarren merged commit c8eba6e into publiclab:main Apr 4, 2019
@kaustubh-nair
Copy link
Member Author

Awesome, thanks
@cesswairimu Please mention which sections you are improving on(whenever you do) so that we don't end up working on the same thing. 😃

@cesswairimu
Copy link
Collaborator

Yeah great idea, I had implemented comments_controller tests before I saw your pr 🤦‍♀️, I am currently implementing tag, images controller tests and figuring out the sessions_controller tests will open a wip too. Thanks @kaustubh-nair

@kaustubh-nair kaustubh-nair mentioned this pull request Apr 5, 2019
Closed
icarito pushed a commit that referenced this pull request Apr 7, 2019
@kaustubh-nair @icarito
Add tests for comments and maps (#467)
5ec6984
@jywarren jywarren mentioned this pull request Apr 16, 2019
Merged
chen-robert pushed a commit to chen-robert/mapknitter that referenced this pull request Dec 5, 2019
@kaustubh-nair @chen-robert
Add tests for comments and maps (publiclab#467)
2aea7b3
jywarren added a commit that referenced this pull request May 5, 2020
@alaxalves @icarito
@rarrunategu1 @jywarren @milomacphail @sonali9696 @ananya @dependabot @sashadev-sky @kaustubh-nair @divyabaid16 @grvsachdeva @govindjeevan @cesswairimu
Get Mapknitter running into the Google Cloud v2 (#1273)
a381a0c 
* Shortening docker image in ~30%

* Caching bundle, gathering env variables and using newer sintax

* Creating startup script and env file

* Improving travis CI configuration

* Loading assets in production env

* Allow uglifier to interpret ES6

* Fix start command

* Fix travis script

* Tweak travis script

* Add delay

* Revert assets changes

* Return to Mysql5.7

* Tweak travis script

* Fix make redeploy-container command

* Add db migrate and precompile step.

* Add bower install to Makefile

* Clean after docker run. Avoid one bower run.

* Changes to be able to build container in Google Cloud

* Remove spurious symlink

* Copy config examples when making build

* Export env variable name

* Tag cloud image

* Add timeout

* Push to cloud registry

* Fix jenkins build error with docker-compose tty

* Add app to container and .dockerignore all else

* Copy configuration files when deploying to GCE

* Allow copy config to container

* Time extended (for cloud build & push)

* Delete redundant index.html.erb file (#427)

* Setupcoveralls (#438)

* Add coveralls

* Fix gemfile

* Fix env variable

* Add coveralls token

* Update README.md

* Remove legacy image controller code #404 (#417)

Deleted the lines from the selection indicated in the issue.

* Change comment count on comment creation via AJAX #441 (#443)

This closes issue #441 "Change comment count on comment creation via AJAX #441" by incrementing comments-number each time a new comment is added. This would ensure that the counter indicating the number of comments is increased without needing to refresh the page.

* update syntax of active record query(license method) (#439)

Fixes #437

* Docker improve rebased (#450)

* Shortening docker image in ~30%

* Caching bundle, gathering env variables and using newer sintax

* Creating startup script and env file

* Improving travis CI configuration

* Loading assets in production env

* Allow uglifier to interpret ES6

* Don't dettach when building container in travis

* Fix start command

* Fix travis script

* Try to resolve travis tests invocation

* Tweak travis script

* Add delay

* Bundle install before db setup

* Shortening docker image in ~30%

* Caching bundle, gathering env variables and using newer sintax

* Creating startup script and env file

* Improving travis CI configuration

* Loading assets in production env

* Allow uglifier to interpret ES6

* Fix start command

* Fix travis script

* Tweak travis script

* Add delay

* Revert assets changes

* Return to Mysql5.7

* Tweak travis script

* Fix make redeploy-container command

* Add db migrate and precompile step.

* Add bower install to Makefile

* Clean after docker run. Avoid one bower run.

* updte pr template (#448)

* Bump recaptcha from 4.13.1 to 4.13.2 (#452)

Bumps [recaptcha](https://github.com/ambethia/recaptcha) from 4.13.1 to 4.13.2.
- [Release notes](https://github.com/ambethia/recaptcha/releases)
- [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md)
- [Commits](ambethia/recaptcha@v4.13.1...v4.13.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Restructure rake test task runner (#380)

* add a mysql setup file

* Squash commits

* Update README.md (#456)

* Change run to exec (#457)

* Bump paperclip from 4.2.4 to 4.3.7 (#285)

Bumps [paperclip](https://github.com/thoughtbot/paperclip) from 4.2.4 to 4.3.7.
- [Release notes](https://github.com/thoughtbot/paperclip/releases)
- [Changelog](https://github.com/thoughtbot/paperclip/blob/v4.3.7/NEWS)
- [Commits](thoughtbot/paperclip@v4.2.4...v4.3.7)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump test-unit from 3.3.0 to 3.3.1 (#458)

Bumps [test-unit](https://github.com/test-unit/test-unit) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/test-unit/test-unit/releases)
- [Commits](test-unit/test-unit@3.3.0...3.3.1)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* Bump coveralls from 0.7.1 to 0.8.22 (#453)

Bumps [coveralls](https://coveralls.io) from 0.7.1 to 0.8.22.

Signed-off-by: dependabot[bot] <support@dependabot.com>

* gridview aligned (#464)

* Alert improvement and adding byebug gem (#383)

* byebug gem added and alerts in separate file

* adding byebug history to gitignore

* adding timestamp to redirect

* added z-index to render login dropdown above leaflet icon

* fixed image partial rendering when no images (#423)

* fixed image partial rendering when no images.

* toggle no images <p> om upload

* fixed image partial rendering when no images.

* Bump recaptcha from 4.13.2 to 4.14.0 (#471)

Bumps [recaptcha](https://github.com/ambethia/recaptcha) from 4.13.2 to 4.14.0.
- [Release notes](https://github.com/ambethia/recaptcha/releases)
- [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md)
- [Commits](ambethia/recaptcha@v4.13.2...v4.14.0)

Signed-off-by: dependabot[bot] <support@dependabot.com>

* add a flash error when adding tags and not logged in (#473)

* Upgrade app to Bootstrap 4 (#480)

* Bootstrap 4 small button fixes (#488)

* Add tests for comments and maps (#467)

* Updated query style (#436) (#469)

* Dynamic ports (#462)

* Dynamic port in compose file

* Omit setting container name

* Add initial sql dump entry

* Avoid resetting database on build

* Shortening docker image in ~30%

* Caching bundle, gathering env variables and using newer sintax

* Creating startup script and env file

* Improving travis CI configuration

* Loading assets in production env

* Tweak travis script

* Roll back to using Debian 9 with custom built GDAL (#489)

* Switch back to Debian 9 Stretch

* Simplify docker image

* Bump Ruby to 2.4.6

* Re-add dependency

* Add dependency (zip)

* Try pip install gdal

* Install libgdal-dev

* Revert attept to use pip

* Bump ruby

* Avoid naming containers in compose file

* Avoid overwriting database on redeploy-container

* Allow to load mysql dump

* Include own GDAL packages

* Disable ipv6 to prevent error

* Add missing Amazon S3 yml to Makefile

* Document unstable instance

* Changes to be able to build container in Google Cloud

* Copy config examples when making build

* Add app to container and .dockerignore all else

* Fixed missed merge

* Add db configurability by env vars for containers

* Fix db config

* Copy configs

* Switch keyserver

* Add env vars, tweak make

* Substitute env vars parameters

* Env var control

* Show env vars

* env not ENV

* add DB_SOCKET

* Add recomended parameters

* Not deploy app engine, show cloudsql dir

* Omit list cloudsql dir

* Added correct image tag

* Add database parameters as env vars

* Support $PORT env var

* Using Node 12 and Yarn for Dockerfile.txt as well

* Changing Passenger's port on production env

* Setting local db for travis

* set .env PORT to $PORT

* Remove .env

* Compose environment variableZ fallback

* Revert all files under /app to versions in main

* Revert to main

* Delete unneeded files

* Remove extra files from rebase

* Add bundle install as build step

* Deleted not needed Dockerfile

* Missed RUN in Dockerfile

* Add precompile step

* Hardcode environment at build time

* Adding missing yaml and update bootsnap version

* Omit /app/tmp from volume

* Revert try to get precompile to work

* Clean up patch for merging

* List variables in app.yaml

* Tweak for jenkins

* Add .env for jenkins

* Fix PORT for jenkins/docker-compose

* Address PORT properly

* New form ports

* Enclose docker-compose ports in quotes

* ports yaml should be object not array

* Try different format for ports

* Try docker-compose format

* Redirect script for AppEngine

* Try to revertt to working condition for appengine

* Point PORT in Procfile

* Revert to known good config in appengine

* Tweak assets precompilation

* Restore PORT setting

* Add redirect to map /warps directory to legacy archive

* Add .env for jenkins/docker-compose

* Add hardcoded route to legacy warps

* Remove .env for appengine

* Satisfy appengine docker-compose

* Ignore app.yaml

* Ignore app.yaml secrets

* Satisfy Jenkins wihout hurting appengine hopefully

Co-authored-by: Sebastian Silva <sebastian@fuentelibre.org>
Co-authored-by: rarrunategu1 <parker.rose@ymail.com>
Co-authored-by: Jeffrey Warren <jeff@unterbahn.com>
Co-authored-by: Milo MacPhail <40954168+milomacphail@users.noreply.github.com>
Co-authored-by: Sonali Agrawal <sonali9696@gmail.com>
Co-authored-by: Ananya Agrawal <33188930+ananya@users.noreply.github.com>
Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com>
Co-authored-by: Kaustubh Nair <kaustubh.nair@iiitb.org>
Co-authored-by: Divya Baid <32747809+divyabaid16@users.noreply.github.com>
Co-authored-by: Gaurav Sachdeva <sachdeva.gaurav1997@gmail.com>
Co-authored-by: Govind Jeevan <govindjeevan7@gmail.com>
Co-authored-by: Cess <cessmbuguar@gmail.com>
Co-authored-by: Stefanni <stefannibrasil@gmail.com>
Co-authored-by: hc-barker <hc-barker@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaustubh-nair @jywarren @cesswairimu