Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn upgrade #702

Merged
merged 17 commits into from
Jun 17, 2019
Merged

Yarn upgrade #702

merged 17 commits into from
Jun 17, 2019

Conversation

kaustubh-nair
Copy link
Member

@kaustubh-nair kaustubh-nair commented Jun 16, 2019

Fixes #351

Summary of PR:

@codeclimate
Copy link

codeclimate bot commented Jun 16, 2019

Code Climate has analyzed commit 7e15726 and detected 0 issues on this pull request.

View more on Code Climate.

Co-authored-by: Álax de Carvalho Alves <alaxallves@gmail.com>
@kaustubh-nair
Copy link
Member Author

@publiclab/mapknitter-reviewers This is ready for merge. Please review.
Thanks

@jywarren jywarren merged commit 5673c03 into main Jun 17, 2019
@jywarren
Copy link
Member

Awesome work!!! Great job! We should be able to turn on dependabot for JavaScript now.

@jywarren
Copy link
Member

Noting to all @publiclab/mapknitter-reviewers

@alaxalves alaxalves deleted the yarn branch June 17, 2019 12:56
@alaxalves alaxalves mentioned this pull request Jul 4, 2019
5 tasks
chen-robert pushed a commit to chen-robert/mapknitter that referenced this pull request Dec 5, 2019
* Add yarn

* Remove error log

* Modify package.json

* Add yarn install to start.sh

* Add leaflet google

* Remove leaflet-google from package json

* remove passenger error logs

* Fix install script

* Remove flag

* Fix gemfile

* Fix conflicts

* Fix gemfile.lock

* Run asset-precompile on travis

* Run create only for production

* Change permissions of exporter script

* Cherry pick local builds for travis runners, publiclab#672

Co-authored-by: Álax de Carvalho Alves <alaxallves@gmail.com>

* Fix rubocop offence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch from Bower to Yarn for JavaScript dependencies
3 participants