Remove "Show More" button from tables (#10891)

* Remove "Show More" button from tables

Fixes #10817

* Resolve failing tests

I wasn't sure about the 5 to 3 part, and has changed the z-index right now, as it was the only plausible change I could figure out.

* Update _notes.html.erb

* Update _notes.html.erb

* Update node_shared_test.rb

app/views/grids/_notes.html.erb

@@ -67,14 +67,6 @@
     <% end %>
   </tr>
 <% end %>
-<% if nodes.count > 10 %>
-    <tfoot>
-      <th class="show-all" id="notes-table-footer" style="min-width: 110px;"><a style="cursor: pointer;">Show more <b class="caret"></b></a></th>
-      <th></th>
-      <th></th>
-      <th></th>
-    </tfoot>
-<% end %>
 </table>
 </div>
 
@@ -91,26 +83,13 @@
   <p><i>Activities should include a materials list, costs and a step-by-step guide to construction with photos. Learn what <a href="https://publiclab.org/notes/warren/09-17-2016/what-makes-a-good-activity">makes a good activity here</a>.</i>
   </p>
 <% end %>
-
+  
 <script>
 (function(){
-  $(".<%= className %>-<%= randomSeed %> .show-all a").click(function(event) {
-    var cName = ".<%= className %>-<%= randomSeed %>";
-    var sName = cName + " tr.extra";
-    $(sName).toggleClass("hide");
-    if ($(sName)[0].classList.contains("hide"))
-      var hiding = true;    
-    var myElement = event.target;    
-    if (event.target.classList.contains("caret")) 
-      myElement = event.target.parentElement;
-    if (!hiding) 
-      myElement.innerHTML = 'Show less <b class="caret" style = "transform: rotate(180deg);"></b>';
-    else
-      myElement.innerHTML = 'Show more <b class="caret"></b>';
-  });
   //setupGridSorters(".<%= className %>-<%= randomSeed %>"); Should order the items by time. Commented out because it reorders the items each time show more/less is clicked
 })()
 </script>
+
 <style>
   th {
     position: sticky;

test/unit/node_shared_test.rb

@@ -40,7 +40,7 @@ class NodeSharedTest < ActiveSupport::TestCase
     assert html
     assert_equal 1, html.scan('<table class="table inline-grid notes-grid notes-grid-test notes-grid-test-').length
     assert_equal 1, html.scan('<table').length
-    assert_equal 5, html.scan('notes-grid-test').length
+    assert_equal 3, html.scan('notes-grid-test').length
     assert html.scan('<td class="title">').length > 1
   end
 
@@ -80,7 +80,7 @@ class NodeSharedTest < ActiveSupport::TestCase
     assert html
     assert_equal 1, html.scan('<table class="table inline-grid notes-grid notes-grid-activity-spectrometer notes-grid-activity-spectrometer-').length
     assert_equal 1, html.scan('<table').length
-    assert_equal 5, html.scan('notes-grid-activity-spectrometer').length
+    assert_equal 3, html.scan('notes-grid-activity-spectrometer').length
     assert_equal 1, html.scan('<td class="title">').length
   end
 
@@ -90,7 +90,7 @@ class NodeSharedTest < ActiveSupport::TestCase
     assert html
     assert_equal 1, html.scan('<table class="table inline-grid questions-grid questions-grid-spectrometer questions-grid-spectrometer-').length
     assert_equal 1, html.scan('<table').length
-    assert_equal 5, html.scan('questions-grid-spectrometer').length
+    assert_equal 3, html.scan('questions-grid-spectrometer').length
     assert html.scan('<td class="title">').length > 1
   end
 
@@ -102,7 +102,7 @@ class NodeSharedTest < ActiveSupport::TestCase
     assert_equal 1, html.scan('<table class="table inline-grid activity-grid activity-grid-spectrometer activity-grid-spectrometer-').length
     assert_equal 7, html.scan('<td').length
     assert_equal 1, html.scan('<table').length
-    assert_equal 5, html.scan('activity-grid-spectrometer').length
+    assert_equal 3, html.scan('activity-grid-spectrometer').length
     assert_equal 1, html.scan('<td class="title">').length
   end
 
@@ -112,7 +112,7 @@ class NodeSharedTest < ActiveSupport::TestCase
     assert html
     assert_equal 1, html.scan('<table class="table inline-grid upgrades-grid upgrades-grid-latest upgrades-grid-latest-').length
     assert_equal 1, html.scan('<table').length
-    assert_equal 5, html.scan('upgrades-grid-latest').length
+    assert_equal 3, html.scan('upgrades-grid-latest').length
     assert html.scan('<td class="title">').length > 1
   end
 
@@ -203,7 +203,7 @@ class NodeSharedTest < ActiveSupport::TestCase
     assert html
     assert_equal 1, html.scan('<table class="table inline-grid notes-grid notes-grid-test notes-grid-test-').length
     assert_equal 1, html.scan('<table').length
-    assert_equal 5, html.scan('notes-grid-test').length
+    assert_equal 3, html.scan('notes-grid-test').length
     assert_equal 5, html.scan('<td').length
   end
 
@@ -213,7 +213,7 @@ class NodeSharedTest < ActiveSupport::TestCase
     assert html
     assert_equal 1, html.scan('<table class="table inline-grid questions-grid questions-grid-spectrometer questions-grid-spectrometer-').length
     assert_equal 1, html.scan('<table').length
-    assert_equal 5, html.scan('questions-grid-spectrometer').length
+    assert_equal 3, html.scan('questions-grid-spectrometer').length
     assert html.scan('<td class="title">').length > 1
   end
 
@@ -223,7 +223,7 @@ class NodeSharedTest < ActiveSupport::TestCase
     assert html
     assert_equal 1, html.scan('<table class="table inline-grid questions-grid questions-grid-spectrometer questions-grid-spectrometer-').length
     assert_equal 1, html.scan('<table').length
-    assert_equal 5, html.scan('questions-grid-spectrometer').length
+    assert_equal 3, html.scan('questions-grid-spectrometer').length
     assert html.scan('<td class="title">').length > 1
   end
 
@@ -235,7 +235,7 @@ class NodeSharedTest < ActiveSupport::TestCase
     assert_equal 1, html.scan('<table class="table inline-grid activity-grid activity-grid-spectrometer activity-grid-spectrometer-').length
     assert_equal 4, html.scan('<td').length
     assert_equal 1, html.scan('<table').length
-    assert_equal 5, html.scan('activity-grid-spectrometer').length
+    assert_equal 3, html.scan('activity-grid-spectrometer').length
   end
 
   test 'about ability of power tags to exclude tags like [upgrades:foo!foo1]' do
@@ -244,7 +244,7 @@ class NodeSharedTest < ActiveSupport::TestCase
     assert html
     assert_equal 1, html.scan('<table class="table inline-grid upgrades-grid upgrades-grid-latest upgrades-grid-latest-').length
     assert_equal 1, html.scan('<table').length
-    assert_equal 5, html.scan('upgrades-grid-latest').length
+    assert_equal 3, html.scan('upgrades-grid-latest').length
     assert html.scan('<td class="title">').length > 1
   end