Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add up/down arrows icon next to sortable headers on /tags page #2331

Closed
jywarren opened this issue Feb 15, 2018 · 7 comments
Closed

Add up/down arrows icon next to sortable headers on /tags page #2331

jywarren opened this issue Feb 15, 2018 · 7 comments
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration enhancement explains that the issue is to improve upon one of our existing features fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute HTML

Comments

@jywarren
Copy link
Member

The Tags page is at https://publiclab.org/tags -- and you can now sort by clicking the table headers, which is awesome. ( @ebarry )

But we'd like to better indicate that kind of sorting -- using an icon indicating sorting, like this:

Name ↕️

https://fontawesome.com/icons/arrows-alt-v?style=solid is nice -- so,

<i class="fa fa-arrows-alt-v"></i> would go next to each of these lines:

<th><a href = "<%= tags_path %>?sort=name"><%= t('tag.index.tag') %></a></th>
<th><a href = "<%= tags_path %>?sort=uses"><%= t('tag.index.number_of_uses') %></a></th>
<th><%= t('tag.index.number_of_subscriptions')%></th>
<% if current_user %>
<th><a href = "<%= tags_path %>?sort=subscribers"><%= t('tag.index.subscriptions') %></a></th>
<% end %>

@jywarren jywarren added enhancement explains that the issue is to improve upon one of our existing features help wanted requires help by anyone willing to contribute fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet HTML labels Feb 15, 2018
@sukhbir-singh
Copy link
Contributor

@jywarren I want to work on this !!

@ebarry
Copy link
Member

ebarry commented Feb 15, 2018

Awesome! !! Can someone investigate the "design pattern" for sorting that seems to be different on https://publiclab.org/wiki ?

screen shot 2018-02-15 at 10 55 25 am

What is we decided to aim for the same pattern at the top of:

@grvsachdeva
Copy link
Member

grvsachdeva commented Feb 15, 2018

Hi @jywarren @ebarry we sort on people page by last activity only and sorting style differs on wiki and tags page so yes the same pattern on top of both pages is a good idea

@grvsachdeva
Copy link
Member

Also, we can make sorting on people page too, what you think @jywarren @ebarry

@jywarren
Copy link
Member Author

Agreed -- let's make a new issue to track implementation of this design pattern (clicking on headers, which is nice and compact, and matches our activity/question grids too) across all tables. Thanks!

@jywarren
Copy link
Member Author

I'm not going to close this issue just yet until we open a new one with the follow-ups @Gauravano and @ebarry have suggested, as a checklist. Thanks, everybody!!!

@jywarren jywarren added the break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration label Feb 15, 2018
@jywarren
Copy link
Member Author

Awesome! Closing this one then. Thanks so much!!! 👍

@ebarry ebarry added this to the Tagging and topics milestone Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration enhancement explains that the issue is to improve upon one of our existing features fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute HTML
Projects
None yet
Development

No branches or pull requests

4 participants