Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to sort tags alphabetically #1704 #1714

Merged
merged 8 commits into from
Oct 24, 2017

Conversation

sagarpreet-chadha
Copy link
Contributor

@sagarpreet-chadha sagarpreet-chadha commented Oct 23, 2017

This solves #1704 .
@jywarren sir...kindly review this ! Thank you !

Sort By button added with two types of sorting methods :
1.) By number of uses and
2.) Alphabetically
screen shot 2017-10-24 at 4 15 42 am

Search Box added to search Tags starting with any prefix ---%
screen shot 2017-10-24 at 4 16 14 am
Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • all tests pass -- rake test:all
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request is descriptively named with #number reference back to original issue

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays. Please alert developers on plots-dev@googlegroups.com when your request is ready or if you need assistance.

Thanks!

@PublicLabBot
Copy link

PublicLabBot commented Oct 23, 2017

1 Message
📖 @sagarpreet-chadha Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

@jywarren
Copy link
Member

I made one small adjustment to the style of the input (following Bootstrap classnames) but this looks perfect -- merging now, and thanks!!!

@jywarren jywarren merged commit 65e072e into publiclab:master Oct 24, 2017
@sagarpreet-chadha sagarpreet-chadha deleted the patch-6 branch October 24, 2017 17:42
@ebarry
Copy link
Member

ebarry commented Oct 24, 2017

This is really exciting, a first in the 7 year history of the Public Lab community which we've been needing this whole time! thank you

@ebarry
Copy link
Member

ebarry commented Feb 15, 2018

Hi @sagarpreet-chadha -- i love this feature so much! I use it all the time, but starting sometime last week (i'm not sure exactly when), the dropdown menu for sorting on the tags page went away -- do you know where it went? Thank you!!!!

@grvsachdeva
Copy link
Member

hi @ebarry actually recently the sorting button has been removed and table headers are now used as buttons for sorting tags like this
tagsort
I guess we need to make changes so users get to know about this thing - how about adding tooltips?

@ebarry
Copy link
Member

ebarry commented Feb 15, 2018

oh wow, thank you!!!!! I had missed that entirely!!!!! Thanks for bringing me back up to speed.
I see there's also an issue going, i'll check in over there: #2331 Have a great day!

@grvsachdeva
Copy link
Member

Have a great day!

you too 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants