-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contribution guidelines #2341
Comments
Agreed -- this sounds great. Also we can change
https://github.com/publiclab/plots2/blob/master/.github/PULL_REQUEST_TEMPLATE.md
or https://github.com/publiclab/plots2/blob/master/.github/ISSUE_TEMPLATE.md
as well. I'd be happy to review a PR about this with an initial copy of
suggested labels maybe from #2231, but are we sure non-contributors can add
labels themselves?
…On Thu, Feb 15, 2018 at 1:16 PM, Sidharth Bansal ***@***.***> wrote:
Please describe the problem (or idea)
At public labs we are now using a new pr label and issue label system as
discussed in #2231 <#2231>. One
problem with the new label system is the newcomers are not having knowledge
of our existing label system
What happened just before the problem occurred? Or what problem could this
idea solve?
I think one solution is to include the link to the contributors page (
https://github.com/publiclab/plots2/blob/master/CONTRIBUTING.md) in all
the first timers issue so that they will read and do the prs accordingly.
For that we need to change the contributors page
This is a part of #2231 <#2231>
@jywarren <https://github.com/jywarren> @ebarry
<https://github.com/ebarry> what do you suggest??
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2341>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJyHy2KAn3rPLgGjksLU14QFls8_dks5tVHSRgaJpZM4SHSDu>
.
|
I am little bit inclined to teaching them how to add labels if they don't know how to add them. |
Oh, sorry i meant like are we sure they even have permissions to change labels? I sometimes forget what i'm able to do as a maintainer :-) |
+1 teaching! |
No, they can't add labels. So, let's think what alternative can be adopted. |
My mistake 😢 |
if a label is assigned to them, can they then add labels?
…On Thu, Feb 15, 2018 at 6:12 PM, Sidharth Bansal ***@***.***> wrote:
No, they can't add labels. So, let's think what alternative can be adopted.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2341 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ_bPrOiEPMyUpzdU9p-QBVrinn2Vks5tVLnNgaJpZM4SHSDu>
.
|
np! There might be something we could do with a bot, maybe, but I don't
know. We could ask them to ping someone for labeling help via
`@publiclab/______`?
…On Thu, Feb 15, 2018 at 6:12 PM, Sidharth Bansal ***@***.***> wrote:
My mistake 😢
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2341 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ0ecjMFh_e8goOd5jPO7Q8IX9Phsks5tVLnugaJpZM4SHSDu>
.
|
We can check this. I will create a new account now and see what happens |
Asking them to ping is a great option |
oh, darn -- you can't assign issues to someone who's not a contributor! :-( |
Added to GCI dashboard |
This task is published on GCI dashboard. Thanks all. |
Is this issue still open? I'd like to work on it... I'm a GCI candidate. |
Yeah |
https://github.com/publiclab/plots2/blob/master/CONTRIBUTING.md |
Location is right |
Which is the file to be updated? Or I have to make a PR for this issue? |
I think we need to create a new file in doc folder. |
Ok... It can be like this file right? https://github.com/publiclab/plots2/blob/master/doc/GCI_MENTOR_GUIDELINES.md |
Yeah
…On Thu, Nov 15, 2018, 8:31 PM Oorjit Chowdhary ***@***.***> wrote:
Ok... It can be like this file right?
https://github.com/publiclab/plots2/blob/master/doc/GCI_MENTOR_GUIDELINES.md
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#2341 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AUACQ6WeTs0vxwoCBhlrqavtfbo7gd7oks5uvYHZgaJpZM4SHSDu>
.
|
Ohk.. Then I'll claim this task on the GCI platform |
Pls review #3981 ... Thanks.. 😄 |
@oorjitchowdhary can you please close #2341 and #2231 once #3981 is merged? |
@SidharthBansal Okay sure |
Please describe the problem (or idea)
At public labs we are now using a new pr label and issue label system as discussed in #2231. One problem with the new label system is the newcomers are not having knowledge of our existing label system
The text was updated successfully, but these errors were encountered: