Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI, design and testing for publiclab digest feature #2694

Closed
ViditChitkara opened this issue May 5, 2018 · 4 comments · Fixed by #2711
Closed

UI, design and testing for publiclab digest feature #2694

ViditChitkara opened this issue May 5, 2018 · 4 comments · Fixed by #2711
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration design issue requires more design work and discussion (i.e. mockups and sketches) more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem summer-of-code

Comments

@ViditChitkara
Copy link
Member

Part of #2104

Design

A possible design for the digest could be:-
digest-1

Testing

  • As the digest feature comes online, we could test it with the help of UserTag digest:weekly and digest:daily .
  • In the initial stages, these tags will be assigned to a few reviewers and maintainers.
  • Only those people having such tags would receive digest emails. Subsequently, we could expand this to a larger lot of people.
@ViditChitkara
Copy link
Member Author

ViditChitkara commented May 5, 2018

@jywarren if we could add more details to it. (Please edit this, if there is anything missing)
Once we finalize the design, I could create a pr for this.

@ViditChitkara ViditChitkara added design issue requires more design work and discussion (i.e. mockups and sketches) break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration summer-of-code more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem labels May 5, 2018
@jywarren
Copy link
Member

jywarren commented May 8, 2018

Hi, is this in the email or on the digests page at https://publiclab.org/subscriptions/digest ?

I think probably the initial design we need to come up with is for email, and I think we ought to start with the simplest -- just a bulleted list. Then we could think about how to organize things by, say, tag?

What if we also thought about a method for organizing a set of posts by tag, generically -- so like Tag.group_by_tag(@nodes) which returns an array of arrays... this could be used to generate separate lists in HTML or in the email itself? What do you think?

@ViditChitkara
Copy link
Member Author

ViditChitkara commented May 8, 2018

Hi @jywarren, this is the email design. I have some code ready for this. Sure, we could start with something basic, figure out the functionality at the backend and then finally reach at this design.
Talking about the tag thing, may be we could add some sort of material chips or tooltips or something to show the tagnames for each of the nodes?
What do you say?

@jywarren
Copy link
Member

jywarren commented May 8, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration design issue requires more design work and discussion (i.e. mockups and sketches) more-detail-please issue lacks proper description and perhaps needs code links or the location of the problem summer-of-code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants