Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dropdown icon adjacent to the navbar items where required #3324

Closed
grvsachdeva opened this issue Sep 14, 2018 · 5 comments
Closed

Add dropdown icon adjacent to the navbar items where required #3324

grvsachdeva opened this issue Sep 14, 2018 · 5 comments

Comments

@grvsachdeva
Copy link
Member

grvsachdeva commented Sep 14, 2018

We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.

We used to have buttons in the Navbar some time back which clearly guide people to explore options but with links in the Navbar, a site visitor may think of them as a direct link. So, dropdown icon needs to be added adjacent to the dropdown Navbar link.

Hint: You need to make changes in this https://github.com/publiclab/plots2/blob/master/app/views/layouts/_header.html.erb file.

dropdown_gci

@jywarren
Copy link
Member

jywarren commented Sep 14, 2018 via email

@grvsachdeva
Copy link
Member Author

Opened separate issue at #3328 for icons @jywarren. I just added 2 points and 3rd point would be innovation from a GCI student. Also, do you think we should clean these comments?

@jywarren
Copy link
Member

jywarren commented Sep 14, 2018 via email

@SidharthBansal
Copy link
Member

This task is published on GCI dashboard. Thanks all.

@prajwalkpatil
Copy link

Hi, i am GCI student please review on - my pull request
#3886
and help me to improve.
Thanks
Prajwal Patil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants