-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dropdown icon adjacent to the navbar items where required #3324
Labels
Comments
There were also some additional changes removing icons which we may want to
re-add, for example to replace "Dashboard" with a house icon and "Profile"
with a person icon. This keeps things more compact, and we had buttons for
Store and Donate too...
The commit that changed this was here:
8252c21#diff-faf6482c7d306c24c4e64dcdf191f7f4
This could be dealt with in a separate issue (or by a second person)
however! The original issue looks like a great first-timers issue :-)
…On Fri, Sep 14, 2018 at 10:46 AM Gaurav Sachdeva ***@***.***> wrote:
We used to have buttons in the Navbar some time back which clearly guide
people to explore options but with links in the Navbar, a site visitor may
think of them as a direct link. So, dropdown icon needs to be added
adjacent to the dropdown Navbar link.
[image: dropdown_gci]
<https://user-images.githubusercontent.com/20878070/45557329-f7dfb200-b85a-11e8-9d00-3fca32d4cdb5.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3324>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ3quO358B4H9zRnxQ5Khe6C2SZUDks5ua8ElgaJpZM4WpaHD>
.
|
sure, go ahead!
…On Fri, Sep 14, 2018 at 1:01 PM Gaurav Sachdeva ***@***.***> wrote:
Opened separate issue at #3328
<#3328> for icons @jywarren
<https://github.com/jywarren>. I just added 2 points and 3rd point would
be innovation from a GCI student. Also, do you think we should clean these
comments?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3324 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABfJ7JY31oEiSWnFtxcTbEzo1tOhuP0ks5ua-CtgaJpZM4WpaHD>
.
|
78 tasks
This task is published on GCI dashboard. Thanks all. |
Hi, i am GCI student please review on - my pull request |
This was referenced Nov 20, 2018
Closed
Closed
Merged
Closed
77 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are preparing to participate in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more.
We used to have buttons in the Navbar some time back which clearly guide people to explore options but with links in the Navbar, a site visitor may think of them as a direct link. So, dropdown icon needs to be added adjacent to the dropdown Navbar link.
Hint: You need to make changes in this https://github.com/publiclab/plots2/blob/master/app/views/layouts/_header.html.erb file.
The text was updated successfully, but these errors were encountered: