Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display message to enter login details. #3646

Closed
Dhiraj240 opened this issue Oct 8, 2018 · 11 comments
Closed

Display message to enter login details. #3646

Dhiraj240 opened this issue Oct 8, 2018 · 11 comments
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed HTML Ruby

Comments

@Dhiraj240
Copy link
Member

Dhiraj240 commented Oct 8, 2018

Please describe the problem (or idea)

If a user do not enter any information in the email and password fields then it should, display a message to enter it.Instead of following.

What happened just before the problem occurred? Or what problem could this idea solve?
screenshot 173

What did you expect to see that you didn't?
A simple form message to ask for details.

Please show us where to look

I need to investigate

What's your PublicLab.org username?

Dhiraj24

This can help us diagnose the issue:

Browser, version, and operating system

Google Chrome, latest and OS is Windows 8.1

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

@Dhiraj240
Copy link
Member Author

Dhiraj240 commented Oct 8, 2018

@SidharthBansal @jywarren i would like to work on it.

@agam-kashyap
Copy link

Hello, I would like to work on this issue as my first time.
Thank you

@SidharthBansal
Copy link
Member

@Dhiraj240 go ahead

@SidharthBansal
Copy link
Member

@agam-kashyap you can try other issues

@grvsachdeva grvsachdeva added bug the issue is regarding one of our programs which faces problems when a certain task is executed Ruby HTML labels Feb 17, 2019
@grvsachdeva
Copy link
Member

Hi @Dhiraj240, have you started working on this one? Thanks!

@grvsachdeva
Copy link
Member

@agam-kashyap you can see more issues at https://code.publiclab.org/#r=all and feel free to comment here in case you can't find any unclaimed issue, we'll try to open one for you. Thanks!

@Dhiraj240
Copy link
Member Author

@gauravano no, i have been more inclined towards mapknitter @agam-kashyap you should start.

@agam-kashyap
Copy link

@Dhiraj240 I will get working on it then. Thanks.

@ananyaarun
Copy link
Member

Hey i would like to take this up. A message like this " There is nobody in our system by that name, are you sure you have the right username?" as seen in other cases would be more suitable in this case.
Also @Dhiraj240 were u able to reproduce this error in ur local installation ?

@ananyaarun
Copy link
Member

ananyaarun commented Mar 12, 2019

@jywarren @gauravano , I notice that the error msg of banned user comes only in the case of not entering both username and password. Should we have separate error msgs for the case of

  1. entering only username
  2. entering only password
  3. username not in DB
  4. password doesn't match username but username in DB

Also though i see this error in the public labs page i don't seem to be able to reproduce it in my local installation.

@grvsachdeva
Copy link
Member

We can perform proper form validation so the form will be submitted only when all the required fields are provided by the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed HTML Ruby
Projects
None yet
Development

No branches or pull requests

5 participants