Added Correct form validation

[ananyaarun]

Fixes #3646

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• PR is descriptively titled 📑
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

Some GIFs to show the working

• Case with Null user name and password followed by correct username and password

• Case to show wrong username and password

Thanks!

[plotsbot]

	2 Messages
📖	@ananyaarun Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[ananyaarun]

@gauravano , i have added the required clause for username and password. Hence the form is never submitted with null values and the wrong alert never shows up. Kindly review :) Thanks !

[grvsachdeva]

Hey @ananyaarun , can't see null value part in the Gif

[ananyaarun]

Hey @gauravano , Sorry the first part of the first gif was unclear. My bad!!
Here is a better gif.

[grvsachdeva]

Nice work @ananyaarun !

[jywarren]

Hmm, is there any way to make it appear more urgently, like with a red highlight? If not, I'm fine merging this! I just don't want people to get confused as to why the button isn't working, and maybe not noticing the messages. Thanks!

[ananyaarun]

@jywarren , There is a pop up that says "pls enter this field" when login doesnt work. So i dont think the user will be confused ?

[jywarren]

Ok, I think this works then! I was just worried maybe it wasn't noticable enough but you're probably right and we can do some user testing to be sure. Thanks, merging now!!!