Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong error msg during signup #5115

Closed
ananyaarun opened this issue Mar 16, 2019 · 10 comments
Closed

Wrong error msg during signup #5115

ananyaarun opened this issue Mar 16, 2019 · 10 comments
Labels
help wanted requires help by anyone willing to contribute Ruby

Comments

@ananyaarun
Copy link
Member

ananyaarun commented Mar 16, 2019

Description

Similar to issue #5114 , while workin on #3340 , I found that entering a different password in the confirm password section when compared to the password section gives this error msg which is misleading to a common user.
signuperror

Solution

The error msg should be changed. The problem was with password not matching confirm password field but error msg hints something about user being not real which is incorrect.

@ananyaarun
Copy link
Member Author

I'd like to work on this. Or if the fix is easy should i make this an FTO ? @gauravano

@IshaGupta18 IshaGupta18 added help wanted requires help by anyone willing to contribute Ruby labels Mar 17, 2019
@CleverFool77
Copy link
Member

@ananyaarun If the password is same, Are you able to form an account in local ? I tried but I'm unable to make an account 🤔

@ananyaarun
Copy link
Member Author

@CleverFool77 , Yes i can create multiple accounts in my local by entering the right details. You must have initially created an account you r working with right now right ? What problem are u facing ? Can u add a screenshot If possible ?

@ananyaarun
Copy link
Member Author

Also there are some required conditions like username should be atleast 3 characters and password must be 8 minimum. Make sure you follow these as well :)

@CleverFool77
Copy link
Member

CleverFool77 commented Mar 17, 2019

I did give correct info but it still says,, you are spam and not human 😢

@CleverFool77
Copy link
Member

And I'm working with admin always.

@CleverFool77
Copy link
Member

@ananyaarun I got my mistake :).

@grvsachdeva
Copy link
Member

Let's do form validation first and then we can resolve this one?

@ananyaarun
Copy link
Member Author

ananyaarun commented Mar 17, 2019

@gauravano , Sure.
Here are the PR's for login and signup form validation corrections.

You can take a look at it whenever you are free :) Thanks!

@sashadev-sky
Copy link
Member

Hey @ananyaarun I can confirm this error has resolved, so closing this issue!
image

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted requires help by anyone willing to contribute Ruby
Projects
None yet
Development

No branches or pull requests

5 participants