-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Idea: powertag pages for activity (activity:foo
) can use the "value" of their key:value pair
#6173
Comments
We currently have this card pull from a page that's redirected to, which is a similar situation. So, we can look at these lines of code: plots2/app/controllers/tag_controller.rb Lines 76 to 82 in 8715803
We can add a condition which detects if it's a elsif tagname = params[:id].match(':') && node = Node.where(slug: tagname)&.first
@wiki = node # skip powertag prefix to find wiki page ...I think? This might take some reworking, but it's worth a try! This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself! |
Thanks to anyone who might be able to reformat this as a first-timers-only issue 💚 |
Hi, I am Jigyasa, and I am an Outreachy 2020 applicant. Is this issue open and can I work on this? |
Hello! I would like to work with this one. |
Hi @Karska-dev we would love your help. Go ahead |
So, if I get it right. This card: should look exactly like this one: Please, correct me where I am wrong! |
HI @Karska-dev , This situation is where there's a power tag in the form In your example, you are showing the tag page for the powertag
|
…ue" of their key:value pair (publiclab#8634) * Fixes publiclab#6173. Powertag pages for activity () can use the ':value' * Fix codeclimate issues * Fix codeclimate issue * Fix codeclimate issue: reduse amount of line by one, get rid from excessive variable
…ue" of their key:value pair (publiclab#8634) * Fixes publiclab#6173. Powertag pages for activity () can use the ':value' * Fix codeclimate issues * Fix codeclimate issue * Fix codeclimate issue: reduse amount of line by one, get rid from excessive variable
…ue" of their key:value pair (publiclab#8634) * Fixes publiclab#6173. Powertag pages for activity () can use the ':value' * Fix codeclimate issues * Fix codeclimate issue * Fix codeclimate issue: reduse amount of line by one, get rid from excessive variable
…ue" of their key:value pair (publiclab#8634) * Fixes publiclab#6173. Powertag pages for activity () can use the ':value' * Fix codeclimate issues * Fix codeclimate issue * Fix codeclimate issue: reduse amount of line by one, get rid from excessive variable
Please describe the desired behavior.
This is a feature idea for convention for powertag pages for
Activity:foo
toFor instance, view https://publiclab.org/tag/activity:microscope to see that the lead card could have a link back to /microscope, and the lead image be pulled from /microscope.
Additional context (optional)
Thank you for reading!
The text was updated successfully, but these errors were encountered: