Remove redundant text written twice: MADE: time #6685

gptshubham595 · 2019-11-05T17:31:10Z

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

 - goto https://publiclab.org
- Head over to blog section

🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
📝 Update
FILE: _notes.html.erb

CHANGES YOU HAVE TO MAKE:
Remove this line: along with "li" tag

plots2/app/views/notes/_notes.html.erb

Line 39 in adea102

    
                             <a> Made: <%= distance_of_time_in_words(node.created_at, Time.current, { include_seconds: false, scope:'datetime.time_ago_in_words' }) %> </a>

See this page for some help in taking your first steps!

💾 Commit your changes
🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

The text was updated successfully, but these errors were encountered:

abhaydrag · 2019-11-05T17:49:09Z

@gptshubham595 should i take this

gptshubham595 · 2019-11-05T17:52:26Z

@123abhay go for it

swathi-0901 · 2019-11-07T06:50:35Z

@123abhay are you working nr this issue else @gptshubham595 can I work on this?

gptshubham595 · 2019-11-07T08:21:15Z

@swathi-0901 wait for one more day then you can proceed

swathi-0901 · 2019-11-09T06:53:33Z

@gptshubham595 can u please tell in detail what is to be done.
thank you

gptshubham595 · 2019-11-09T08:03:49Z

@swathi-0901 sure

gptshubham595 · 2019-11-09T08:05:15Z

You can see this PR once help

#6746

You have to make changes in this file _notes.html.erb

Happy contributing!!

SidharthBansal · 2019-11-09T08:47:05Z

@swathi-0901 I think you are working on a fto issue. One person can take atmost one fto issue. So, you can take other non first timer issues.
First timer issues are only for new contributors. I think you will be happy to take other issues and let new contributors come in at PL
Thanks for understanding Swathi

SidharthBansal · 2019-11-09T08:47:44Z

@gptshubham595 you are requested to add codelinks in the issue body

gptshubham595 · 2019-11-09T10:27:13Z

sure @SidharthBansal Thanks for updating
,Done!

Srija616 · 2020-03-13T17:46:51Z

@keshav234156 @jywarren Hey I have already made two PRs for an FTO, can I claim this issue? Also, I am not clear on what is to be done in this task. I assume, we have to make this an FTO task and in order to do that, figure out the lines to be deleted from the code.

Jigyasa-Kumari · 2020-03-17T07:07:03Z

Hi, I am Jigyasa, and I am an Outreachy 2020 applicant. Is this issue open, and can I work on this?

swarajpure · 2020-06-08T08:41:30Z

Hello, is anyone working on this issue? If no, can I do it?

RuthNjeri · 2020-10-08T17:45:48Z

@cesswairimu, thank you! You can assign this to me, I'd like to work on it.

cesswairimu · 2020-10-08T18:03:57Z

Great, done

RuthNjeri · 2020-10-08T20:10:58Z

@cesswairimu I don't think this issue is still valid, the notes partial has been refactored since this issue was created. When I create a test note, there is no redundancy with the Made: section.

The main branch shows that the line of code suggested in this issue is currently in the card partial and no longer in the file suggested here.

cesswairimu · 2020-10-08T20:23:47Z

Oh yeah you are right. You can edit on that file. Thanks

RuthNjeri · 2020-10-08T20:36:33Z

@cesswairimu Is that line of code still redundant? I guess I can’t pinpoint how it is redundant

…

On Thu, Oct 8, 2020 at 11:24 PM Cess ***@***.***> wrote: Oh yeah you are right. You can edit on that file. Thanks — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#6685 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB2FBWYRIZRF4UZE3CKXXWDSJYNWJANCNFSM4JJFVYXA> .

jywarren · 2020-10-08T21:35:35Z

I think the person was saying it was just telling the "time ago" twice. So, maybe we can remove the "Made:" version? Thanks!

cesswairimu · 2020-10-08T21:38:34Z

Its showing the time on view mode, and also on clicking the three dots like so

RuthNjeri · 2020-10-09T05:24:17Z

That makes sense, thanks @jywarren and @cesswairimu. I'll remove the "Made"

gptshubham595 added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Nov 5, 2019

jywarren added fto-candidate issues which are meant to be solved by first timers but aren't well-formatted yet help wanted requires help by anyone willing to contribute and removed first-timers-only They need to be well-formatted using the First-timers_Issue_Template. labels Nov 5, 2019

SidharthBansal changed the title ~~Remove useless text written twice : MADE : time~~ Remove redundant text written twice: MADE: time Nov 6, 2019

stale bot added the stale label Oct 7, 2020

publiclab deleted a comment from stale bot Oct 8, 2020

stale bot removed the stale label Oct 8, 2020

cesswairimu mentioned this issue Oct 8, 2020

Welcome Outreachy Aspirants Winter 2020 #8448

Closed

cesswairimu assigned RuthNjeri Oct 8, 2020

RuthNjeri mentioned this issue Oct 9, 2020

Remove Redundant Time Text #8503

Merged

5 tasks

jywarren closed this as completed in #8503 Oct 9, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove redundant text written twice: MADE: time #6685

Remove redundant text written twice: MADE: time #6685

gptshubham595 commented Nov 5, 2019 •

edited

Loading

abhaydrag commented Nov 5, 2019

gptshubham595 commented Nov 5, 2019

swathi-0901 commented Nov 7, 2019

gptshubham595 commented Nov 7, 2019

swathi-0901 commented Nov 9, 2019

gptshubham595 commented Nov 9, 2019

gptshubham595 commented Nov 9, 2019 •

edited

Loading

SidharthBansal commented Nov 9, 2019

SidharthBansal commented Nov 9, 2019

gptshubham595 commented Nov 9, 2019 •

edited

Loading

Srija616 commented Mar 13, 2020

Jigyasa-Kumari commented Mar 17, 2020

swarajpure commented Jun 8, 2020

RuthNjeri commented Oct 8, 2020

cesswairimu commented Oct 8, 2020 •

edited

Loading

RuthNjeri commented Oct 8, 2020 •

edited

Loading

cesswairimu commented Oct 8, 2020

RuthNjeri commented Oct 8, 2020 via email •

edited

Loading

jywarren commented Oct 8, 2020

cesswairimu commented Oct 8, 2020

RuthNjeri commented Oct 9, 2020

Remove redundant text written twice: MADE: time #6685

Remove redundant text written twice: MADE: time #6685

Comments

gptshubham595 commented Nov 5, 2019 • edited Loading

🤔 What you will need to know.

📋 Step by Step

Please keep us updated

Is someone else already working on this?

🤔❓ Questions?

abhaydrag commented Nov 5, 2019

gptshubham595 commented Nov 5, 2019

swathi-0901 commented Nov 7, 2019

gptshubham595 commented Nov 7, 2019

swathi-0901 commented Nov 9, 2019

gptshubham595 commented Nov 9, 2019

gptshubham595 commented Nov 9, 2019 • edited Loading

SidharthBansal commented Nov 9, 2019

SidharthBansal commented Nov 9, 2019

gptshubham595 commented Nov 9, 2019 • edited Loading

Srija616 commented Mar 13, 2020

Jigyasa-Kumari commented Mar 17, 2020

swarajpure commented Jun 8, 2020

RuthNjeri commented Oct 8, 2020

cesswairimu commented Oct 8, 2020 • edited Loading

RuthNjeri commented Oct 8, 2020 • edited Loading

cesswairimu commented Oct 8, 2020

RuthNjeri commented Oct 8, 2020 via email • edited Loading

jywarren commented Oct 8, 2020

cesswairimu commented Oct 8, 2020

RuthNjeri commented Oct 9, 2020

gptshubham595 commented Nov 5, 2019 •

edited

Loading

gptshubham595 commented Nov 9, 2019 •

edited

Loading

gptshubham595 commented Nov 9, 2019 •

edited

Loading

cesswairimu commented Oct 8, 2020 •

edited

Loading

RuthNjeri commented Oct 8, 2020 •

edited

Loading

RuthNjeri commented Oct 8, 2020 via email •

edited

Loading