Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompt to Dashboard (/dashboard) to add user location #7084

Closed
nstjean opened this issue Jan 2, 2020 · 6 comments
Closed

Add prompt to Dashboard (/dashboard) to add user location #7084

nstjean opened this issue Jan 2, 2020 · 6 comments

Comments

@nstjean
Copy link
Contributor

nstjean commented Jan 2, 2020

If a user doesn't have a location they should be prompted on the /dashboard to enter one.

Should it be in the main column, something like this?

FireShot Capture 161 - 🎈 Public Lab_ Dashboard - localhost

Or in the sidebar?

FireShot Capture 162 - 🎈 Public Lab_ Dashboard - localhost

If it's in the main column we could add some descriptive text to the box. If it's in the sidebar it matches with the pages and notes, but will be more easily overlooked.

@jywarren
Copy link
Member

jywarren commented Jan 9, 2020

Let's do sidebar! We will also have to be sure this gets reflected in the new dashboard project, which is currently a bit stalled #6229 #6072

Thanks!

@nstjean
Copy link
Contributor Author

nstjean commented Jan 9, 2020

Ahh, perfect! Ok!

@sagarpreet-chadha
Copy link
Contributor

🎉

@nstjean
Copy link
Contributor Author

nstjean commented Jan 13, 2020

Using the wording from #6072 this is what it looks like:

FireShot Capture 205 - 🎈 Public Lab_ Dashboard - localhost

Should we add the line break in a different spot?

FireShot Capture 206 - 🎈 Public Lab_ Dashboard - localhost

@sagarpreet-chadha
Copy link
Contributor

Yes "About location privacy" in next line makes sense. Thanks!

@nstjean
Copy link
Contributor Author

nstjean commented Jan 16, 2020

Reposted as a FTO! #7263

@nstjean nstjean closed this as completed Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants