Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At location button to dashboard sidebar #7263

Closed
5 tasks
nstjean opened this issue Jan 16, 2020 · 5 comments · Fixed by #7265
Closed
5 tasks

At location button to dashboard sidebar #7263

nstjean opened this issue Jan 16, 2020 · 5 comments · Fixed by #7265
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.

Comments

@nstjean
Copy link
Contributor

nstjean commented Jan 16, 2020

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • 📝 Update the file sidebar/_dashboard.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

On line 20 remove this:

And add in this code in its place:

<div style="margin: 2.2rem 0;">
  <a class="btn btn-lg btn-outline-secondary blurred-location-input" submit_to="/profile/tags/create/<%= current_user.uid %>"><i class="fa fa-map-marker" style="color:#c40;"></i> Add your location</a>
  <p style="font-size: smaller; margin: 0.3rem 0;">
    Add your location to see work near you<br>
    <a href="https://publiclab.org/location-privacy" target="_blank">About location privacy »</a>
  </p>
</div>

It will look like this when you are done!

FireShot Capture 225 - 🎈 Public Lab_ Dashboard - localhost

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

@nstjean nstjean added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Jan 16, 2020
@imajit
Copy link
Contributor

imajit commented Jan 16, 2020

Hey ! I'm working on it

@pcube99
Copy link
Contributor

pcube99 commented Jan 16, 2020

Is this issue still up ?
I want to claim it.

@nstjean
Copy link
Contributor Author

nstjean commented Jan 16, 2020

Hi @pcube99 ! @imajit has submitted a pull request for this issue. Take a lot to see if you can find any first-time-only issues that aren't taken.

@imajit
Copy link
Contributor

imajit commented Jan 17, 2020

Hey @nstjean can you review the PR

@imajit
Copy link
Contributor

imajit commented Jan 17, 2020

@pcube99 If you are looking FTO issues you can try #7269 if it has not been claimed

cesswairimu pushed a commit that referenced this issue Jan 17, 2020
* Fixes #7263 At location button to dashboard sidebar

* Fixes #7263 At location button to dashboard sidebar

* Trying new code to fix issue
vinitshahdeo pushed a commit to vinitshahdeo/plots2 that referenced this issue Feb 1, 2020
…ab#7265)

* Fixes publiclab#7263 At location button to dashboard sidebar

* Fixes publiclab#7263 At location button to dashboard sidebar

* Trying new code to fix issue
NitinBhasneria pushed a commit to NitinBhasneria/plots2 that referenced this issue Feb 5, 2020
…ab#7265)

* Fixes publiclab#7263 At location button to dashboard sidebar

* Fixes publiclab#7263 At location button to dashboard sidebar

* Trying new code to fix issue
cesswairimu pushed a commit that referenced this issue Apr 6, 2020
* Fixes #7263 At location button to dashboard sidebar

* Fixes #7263 At location button to dashboard sidebar

* Trying new code to fix issue

* feature suggests tags in subscriptions

* removed trailing white space

* changed .each to .select

* changed .each to .select

* resolved error

* resolved error

* Test run

* Test run

* Test run 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants