Top map only shows for tag "place" and not power tag "place:xx"

[nstjean]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• 📝 Update the file _related.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Right now if you input the tag place the map shows properly as a map across the top of the page instead of in the sidebar.

But if you input the power tag place:xx then it isn't showing properly.

So let's cover our bases by checking both of those options. On this line here:

plots2/app/views/sidebar/_related.html.erb

Line 44 in 2365caa

<% if @node && @node.has_tag("place") && @node.lat && @node.lon %>

Change it to:
<% if @node && (@node.has_tag("place") || @node.has_power_tag("place")) && @node.lat && @node.lon %>

Now it works properly!

• 💾 Commit your changes

• 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

[nstjean]

@jywarren Should this check for the tag place at all? Or only the power tag?

[llabake]

Hi, I would like to claim this.

[nstjean]

@llabake Great, go ahead!

[nstjean]

@llabake I see that you also have publiclab/leaflet-environmental-layers#333 so go ahead and do that one in Leaflet Environmental Layers. I'll have someone else do this one. :)

@sunguru98 You can have this one!

[sssash18]

Can I take up this issue?@nstjean

[nstjean]

@sssash18 This issue has already been claimed, but I know there is one available in Leaflet Environmental Layers: publiclab/leaflet-environmental-layers#322

[sunguru98]

Yayyyyy .. I will do it right away.

[nstjean]

Great! Thank you for your patience. 😃

[sunguru98]

@nstjean Done :)