Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate text for Uploaded images #7991

Open
Tlazypanda opened this issue Jun 4, 2020 · 10 comments
Open

Alternate text for Uploaded images #7991

Tlazypanda opened this issue Jun 4, 2020 · 10 comments
Labels
discussion feature explains that the issue is to add a new feature outreachy

Comments

@Tlazypanda
Copy link
Collaborator

Please describe the desired behavior.
Currently we dont have any alternate text for images across the app. While for the static ones we can add some alt text but for the ones uploaded by the user, its not possible for us to apply the same. So what should be the plausible solution for it?

  • One possible way is to add a field for the user to add alternate text for the image whenever they upload but this won't always ensure that the user does add the alternate text or if they do whether it will be meaningful text relevant to the picture. We can have a special message asking them to add since it will help accessibility of the app and help more sections of society to access it with ease
  • The other solution is to use some image recognition service like aws/microsoft services to determine the image text and accordingly add it as alt text. This might slow down the app and might also require us to tag all our previous data or add our data to their servers.
@Tlazypanda Tlazypanda added feature explains that the issue is to add a new feature discussion outreachy labels Jun 4, 2020
@Tlazypanda
Copy link
Collaborator Author

@jywarren @cesswairimu @emilyashley @SidharthBansal @IshaGupta18 @VladimirMikulic Need your inputs everyone 🎉 Thanks!! ✌️

@VladimirMikulic
Copy link
Contributor

Automation for me is always the way to go :)
Since this is OSS, I understand why other members might not agree with me. (AWS/Google/Microsoft holds the data).

@jywarren is the right person to answer this question.

@Tlazypanda
Copy link
Collaborator Author

Hey @jywarren @cesswairimu @emilyashley @SidharthBansal @IshaGupta18 Looking forward to your inputs 🎉

@jywarren
Copy link
Member

I hear you on automation sounding interesting! But I'm a bit hesitant on the automation front. It might be interesting to read up on and hear from folks who use accessibility software to know if automation (whether as a primary or fall-back method) has been a good solution for people -- and for people with various accessibility needs, for example. That would be a good "source of knowledge" for whether that would be a good approach.

As to alt text and how to store it, it's also a challenge with Markdown. Commonmark, the closest thing to a Markdown standard, shows that alt text is provided for in Markdown: https://spec.commonmark.org/0.29/#example-568

Example: ![alt text](/image.png)

The hard part may be to make it as easy (and encouraged) as possible for authors to add alt text. I think this is very worthwhile and more and more people are taking the time to add alt text to their images. This might mean some coordination with the Editor team over how the alt text should be added -- some brainstorming! Should images without alt text show a little icon overlay asking for alt content? Or something else?

One thing you could then do to have a hybrid approach is that where the editor asks for alt text, you could have a button that says "try to auto-generate a description with Google cloud blablabla" or something (😄 ) and the person would be able to review it to see if it sounds accurate. That way it's a supportive tool, not a default.

Finally, remember that there's a comment editor and a post editor! People upload images in both.

Thank you!!!! This is a really thoughtful issue and I appreciate your time and care on it!!!

@Tlazypanda
Copy link
Collaborator Author

Thanks @jywarren for such a detailed explanation 🎉 Looping in @Shulammite-Aso @keshav234156 @NitinBhasneria @shreyaa-sharmaa What do you think? 😅

@Shulammite-Aso
Copy link
Collaborator

If this is for the main images, maybe we could add an input field just beside the main image field, below the choose file button asking authors to include alternate text. And perhaps a help text too beside it that will hold something like this:

you could have a button that says "try to auto-generate a description with Google cloud blablabla" or something (smile ) and the person would be able to review it to see if it sounds accurate.

For images inside the text body, i don't actually know how exactly we could ask alt text from authors, but maybe if they use markdown, could replacing the 'image description' with their own description do the work?

@Tlazypanda
Copy link
Collaborator Author

Thanks @Shulammite-Aso for your inputs 🎉 It does sound a bit challenging to figure this out 😅 Let's see how it fares

@Tlazypanda
Copy link
Collaborator Author

@jywarren Going through the different providers (microsoft,google etc) the services pricing structure requires us to pay 😅 It's either free for a certain trial period or paid according to the services or features of the api that you are going to require https://azure.microsoft.com/en-in/pricing/details/cognitive-services/computer-vision/

@Tlazypanda
Copy link
Collaborator Author

Tlazypanda commented Aug 22, 2020

Hey @jywarren @cesswairimu 👋

Actually wanted some help with this issue I understand that some work on images has been done by the editor team and am not sure if that will impact this or not ...so far have been able to get the UI for this in place but actual saving action doesn't seem to work could you please point me to which files/functions should be changed for the backend to work 😅 I tried a couple of different combinations with help from @cesswairimu still finding it difficult to couple this with the image model 😅

You can view some of those changes in my pr #8106 and suggest what should my approach be. Thanks 💯

@cesswairimu
Copy link
Collaborator

Sure thing I will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion feature explains that the issue is to add a new feature outreachy
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants