Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Add alternate text for lead images #8106

Closed
wants to merge 2 commits into from

Conversation

Tlazypanda
Copy link
Collaborator

Fixes #7991

work in progress:add alternate text for image

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

Thanks!

@Tlazypanda Tlazypanda requested review from a team as code owners July 2, 2020 12:25
@codecov
Copy link

codecov bot commented Jul 2, 2020

Codecov Report

Merging #8106 (436485a) into main (4cb5740) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head 436485a differs from pull request most recent head ccfaeee. Consider uploading reports for the commit ccfaeee to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8106      +/-   ##
==========================================
- Coverage   81.86%   81.78%   -0.09%     
==========================================
  Files         101      101              
  Lines        5900     5906       +6     
==========================================
  Hits         4830     4830              
- Misses       1070     1076       +6     
Impacted Files Coverage Δ
app/controllers/notes_controller.rb 81.42% <0.00%> (-1.98%) ⬇️

@@ -111,6 +111,9 @@
<p class="ple-help">
<span class="ple-help-minor">Select an optional main image for your post.</span>
</p>
<p>
<input class="form-control input-lg" type="text" id="alt-text" placeholder="Add alternate text for image" value="<% if @node && @node.main_image.photo_text %><%= @node.main_image.photo_text %><% else %><%= params[:photo_text] %><% end %>"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tlazypanda found that the issue is because some notes do not have images hence the nil error..we can use a safe navigator to cater for the nodes without 'main_images' like so

input class="form-control input-lg" type="text" id="alt-text" placeholder="Add alternate text for image" value="<% if @node && @node&.main_image&.photo_text %><%= @node.main_image.photo_text %><% else %><%= params[:photo_text] %><% end %>"/>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tlazypanda I will prioritize this coming week so we can collaborate and have it merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this is v cool! can we see a screenshot at some point? Thanks!!

@Tlazypanda Tlazypanda requested review from a team as code owners September 2, 2020 15:09
@gitpod-io
Copy link

gitpod-io bot commented Sep 2, 2020

@stale
Copy link

stale bot commented Sep 8, 2021

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label 🎉 . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! 💯 Thank you for your contributions! 🙌 🎈.

@stale stale bot added the stale label Sep 8, 2021
@stale stale bot closed this Sep 18, 2021
@noi5e noi5e reopened this Sep 19, 2021
@gitpod-io
Copy link

gitpod-io bot commented Sep 19, 2021

@stale stale bot removed the stale label Sep 19, 2021
@codeclimate
Copy link

codeclimate bot commented Sep 19, 2021

Code Climate has analyzed commit ccfaeee and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@jywarren jywarren changed the title wip: Add alternate text for images wip: Add alternate text for lead images May 24, 2022
@stale
Copy link

stale bot commented Jun 10, 2023

Hi 😄, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label 🎉 . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! 💯 Thank you for your contributions! 🙌 🎈.

@stale stale bot added the stale label Jun 10, 2023
@stale stale bot closed this Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternate text for Uploaded images
4 participants